Activation complex dtype relu6 #23599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I, what remains is the data_classes and stateful
ivy-leaves
added
Array API
|
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
jshepherd01
reviewed
Sep 14, 2023
| @@ -38,8 +38,8 @@ def thresholded_relu( | |||
| return tf.cast(tf.where(x > threshold, x, 0), x.dtype) | |||
|
|
|||
|
|
|||
| @with_unsupported_dtypes({"2.13.0 and below": ("complex",)}, backend_version) | |||
| def relu6(x: Tensor, /, *, out: Optional[Tensor] = None) -> Tensor: | |||
| # @with_unsupported_dtypes({"2.13.0 and below": ("complex",)}, backend_version) | |||
There was a problem hiding this comment.
This line should probably be removed completely rather than just commented out
|
The failed tests seem to be from the tensorflow frontend trying to test with complex numbers, which causes errors in the ground truth. You should probably add complex as an unsupported dtype to specifically the tensorflow frontend function, and change the thing I mentioned above, and then it'll be good to merge |
iababio
pushed a commit
to iababio/ivy
that referenced
this pull request
Sep 27, 2023
druvdub
pushed a commit
to druvdub/ivy
that referenced
this pull request
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for complex dtype for
relu6, as well as_relu6_jax_likefunction