Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added fft2 #23638

Closed
wants to merge 9 commits into from
Closed

Conversation

jaskiratsingh2000
Copy link
Contributor

Closes: #19052 of #15047

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 15, 2023
@jaskiratsingh2000
Copy link
Contributor Author

@DecFox For same same reason the lint is throwing the formatting error for a line. I have corrected it multiple times even then. Can you please check once?
@DecFox

@ivy-seed ivy-seed assigned jieunboy0516 and unassigned DecFox Sep 16, 2023
@jieunboy0516
Copy link
Contributor

Hi @jaskiratsingh2000 , thanks for your contribution to Ivy. Your code looks good to me but I am currently unable to run the unit tests due to a "key error: cpu not found" issue. I will wait for awhile until the issue gets fixed and will return to you to confirm the unit tests are passing!

@jieunboy0516
Copy link
Contributor

jieunboy0516 commented Sep 21, 2023

Sorry @jaskiratsingh2000, turns out there is some issue in your code

    |     fft_first_axis = fft(x, n=s[0] if s else None, axis=axes[0], norm=norm)
    | TypeError: 'int' object is not subscriptable

that is causing the unit tests to fail. Could you please take a look and fix it? Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fft2
6 participants