Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Fmax #23691

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ivy/functional/frontends/paddle/fft.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,27 @@ def irfft(x, n=None, axis=-1.0, norm="backward", name=None):
return time_domain


@with_supported_dtypes(
{"2.5.1 and below": ("complex64", "complex128")},
"paddle",
)
@to_ivy_arrays_and_back
def rfft(x, n=None, axis=-1, norm="backward", name=None):
# Ensure x is a complex type for FFT calculations
x_complex = ivy.astype(x, "complex128")

# Perform FFT
fft_result = ivy.fft(x_complex, n=n, axis=axis, norm=norm)

# Extract positive frequency terms
n = fft_result.shape[axis] if n is None else n
pos_freq_idx = n // 2 + 1
slice_obj = [slice(None)] * len(fft_result.shape)
slice_obj[axis] = slice(0, pos_freq_idx)

return fft_result[tuple(slice_obj)]


@to_ivy_arrays_and_back
def rfftfreq(n, d=1.0, dtype=None, name=None):
dtype = ivy.default_dtype()
Expand Down
3 changes: 3 additions & 0 deletions ivy/functional/frontends/torch/tensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -1110,6 +1110,9 @@ def atan2_(self, other):
self.ivy_array = self.atan2(other).ivy_array
return self

def fmax(self, other):
return torch_frontend.fmax(self, other)

def fmin(self, other):
return torch_frontend.fmin(self, other)

Expand Down
38 changes: 38 additions & 0 deletions ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -6868,6 +6868,44 @@ def test_torch_tensor_floor_(
)


# fmax
@handle_frontend_method(
class_tree=CLASS_TREE,
init_tree="torch.tensor",
method_name="fmax",
dtype_and_x=helpers.dtype_and_values(
available_dtypes=helpers.get_dtypes("float"),
num_arrays=2,
),
)
def test_torch_tensor_fmax(
dtype_and_x,
frontend_method_data,
init_flags,
method_flags,
frontend,
on_device,
backend_fw,
):
input_dtype, x = dtype_and_x
helpers.test_frontend_method(
init_input_dtypes=input_dtype,
backend_to_test=backend_fw,
init_all_as_kwargs_np={
"data": x[0],
},
method_input_dtypes=input_dtype,
method_all_as_kwargs_np={
"other": x[1],
},
frontend_method_data=frontend_method_data,
init_flags=init_flags,
method_flags=method_flags,
frontend=frontend,
on_device=on_device,
)


# fmin
@handle_frontend_method(
class_tree=CLASS_TREE,
Expand Down