Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver handling in svdvals function in torch_frontend #23718

Merged
merged 26 commits into from
Oct 24, 2023
Merged

Driver handling in svdvals function in torch_frontend #23718

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
699e80b
handling driver of svdvals in torch
AhmedHossam23 Sep 14, 2023
337870c
handling the driver and solving the formating issue
AhmedHossam23 Sep 14, 2023
8137331
Handling driver and solving formating issue
AhmedHossam23 Sep 15, 2023
da90906
added the test and simplified the implementation
AhmedHossam23 Sep 23, 2023
791b7e8
solving the formating issue
AhmedHossam23 Sep 23, 2023
3841366
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 Sep 26, 2023
a4a8a41
added the test to test_linalg
AhmedHossam23 Sep 26, 2023
f8eff89
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 Oct 2, 2023
997c5c6
added the driver to the backend
AhmedHossam23 Oct 4, 2023
5df4c6e
🤖 Lint code
ivy-branch Oct 4, 2023
17a6f66
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 Oct 4, 2023
fb6bdcd
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 Oct 8, 2023
0749056
reformatted
AhmedHossam23 Oct 8, 2023
e891edd
test_array_api
AhmedHossam23 Oct 8, 2023
ec4c9c3
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 Oct 8, 2023
ea0e331
Merge branch 'main' into hossam_branch
AhmedHossam23 Oct 9, 2023
d55430d
🤖 Lint code
ivy-branch Oct 9, 2023
a9e575a
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 Oct 16, 2023
adb7cc5
added driver argument and to do comment
AhmedHossam23 Oct 16, 2023
71027ba
Merge branch 'hossam_branch' of https://github.com/AhmedHossam23/ivy …
AhmedHossam23 Oct 16, 2023
ffc36e7
Merge branch 'main' into hossam_branch
AhmedHossam23 Oct 20, 2023
df5368b
🤖 Lint code
ivy-branch Oct 20, 2023
b31bb95
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 Oct 20, 2023
468b869
added driver arg in right way
AhmedHossam23 Oct 20, 2023
b47923e
updates
AhmedHossam23 Oct 20, 2023
c0fa649
🤖 Lint code
ivy-branch Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ivy/functional/frontends/torch/linalg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# local
import math
import torch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! The native torch shouldn't be imported in the frontends, if ivy.svdvals doesn't support this argument yet, you should first implement the new argument in the backend, add the related argument in the tests, and then use the ivy function in this frontend, thanks!

import ivy
import ivy.functional.frontends.torch as torch_frontend
from ivy.functional.frontends.torch.func_wrapper import to_ivy_arrays_and_back
Expand Down Expand Up @@ -310,6 +311,12 @@ def svd(A, /, *, full_matrices=True, driver=None, out=None):
)
def svdvals(A, *, driver=None, out=None):
# TODO: add handling for driver
if driver == "gesvd":
return torch.linalg.svdvals(A, out=out, driver=driver)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I think this could be simplified into ... driver in [...] and they can share a return. Also, please add the test for this argument in the svdvals test in the torch frontend test folder, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have added the test and simplified the function implmentaiton

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test should be modified in test_linalg.py in the torch frontend tests folder within ivy_test, not sure I've missed anything but the file is not shown as changed in the diff of the PR, I don't think the tests are added yet, also, please don't update the test_array_api submodule yet, thanks!

elif driver == "gesvdj":
return torch.linalg.svdvals(A, out=out, driver=driver)
elif driver == "gesvda":
return torch.linalg.svdvals(A, out=out, driver=driver)
return ivy.svdvals(A, out=out)


Expand Down
2 changes: 1 addition & 1 deletion ivy_tests/array_api_testing/test_array_api
Open in desktop
Submodule test_array_api updated 31 files
+48 −1 .github/workflows/numpy.yml
+25 −83 README.md
+5 −7 array_api_tests/__init__.py
+0 −2 array_api_tests/_array_module.py
+16 −0 array_api_tests/conftest.py
+106 −194 array_api_tests/dtype_helpers.py
+17 −63 array_api_tests/hypothesis_helpers.py
+1 −27 array_api_tests/meta/test_hypothesis_helpers.py
+9 −9 array_api_tests/meta/test_pytest_helpers.py
+11 −6 array_api_tests/meta/test_utils.py
+46 −100 array_api_tests/pytest_helpers.py
+38 −57 array_api_tests/test_array_object.py
+61 −91 array_api_tests/test_creation_functions.py
+25 −73 array_api_tests/test_data_type_functions.py
+0 −2 array_api_tests/test_has_names.py
+0 −64 array_api_tests/test_indexing_functions.py
+12 −15 array_api_tests/test_linalg.py
+41 −42 array_api_tests/test_manipulation_functions.py
+194 −276 array_api_tests/test_operators_and_elementwise_functions.py
+16 −31 array_api_tests/test_searching_functions.py
+19 −20 array_api_tests/test_set_functions.py
+94 −151 array_api_tests/test_signatures.py
+17 −16 array_api_tests/test_sorting_functions.py
+11 −7 array_api_tests/test_special_cases.py
+51 −89 array_api_tests/test_statistical_functions.py
+315 −0 array_api_tests/test_type_promotion.py
+6 −10 array_api_tests/test_utility_functions.py
+2 −2 array_api_tests/typing.py
+12 −92 conftest.py
+0 −41 numpy-skips.txt
+1 −1 requirements.txt
Loading