-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver handling in svdvals function in torch_frontend #23718
Merged
Merged
Changes from 17 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
699e80b
handling driver of svdvals in torch
AhmedHossam23 337870c
handling the driver and solving the formating issue
AhmedHossam23 8137331
Handling driver and solving formating issue
AhmedHossam23 da90906
added the test and simplified the implementation
AhmedHossam23 791b7e8
solving the formating issue
AhmedHossam23 3841366
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 a4a8a41
added the test to test_linalg
AhmedHossam23 f8eff89
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 997c5c6
added the driver to the backend
AhmedHossam23 5df4c6e
🤖 Lint code
ivy-branch 17a6f66
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 fb6bdcd
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 0749056
reformatted
AhmedHossam23 e891edd
test_array_api
AhmedHossam23 ec4c9c3
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 ea0e331
Merge branch 'main' into hossam_branch
AhmedHossam23 d55430d
🤖 Lint code
ivy-branch a9e575a
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 adb7cc5
added driver argument and to do comment
AhmedHossam23 71027ba
Merge branch 'hossam_branch' of https://github.com/AhmedHossam23/ivy …
AhmedHossam23 ffc36e7
Merge branch 'main' into hossam_branch
AhmedHossam23 df5368b
🤖 Lint code
ivy-branch b31bb95
Merge branch 'unifyai:main' into hossam_branch
AhmedHossam23 468b869
added driver arg in right way
AhmedHossam23 b47923e
updates
AhmedHossam23 c0fa649
🤖 Lint code
ivy-branch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2263,7 +2263,11 @@ def svd( | |
@handle_array_function | ||
@handle_device | ||
def svdvals( | ||
x: Union[ivy.Array, ivy.NativeArray], /, *, out: Optional[ivy.Array] = None | ||
x: Union[ivy.Array, ivy.NativeArray], | ||
/, | ||
*, | ||
driver: Optional[str], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hey! sure, but could you please at least add this argument to every backend + a todo comment so that its usage won't break when a user use this on a backend other than torch? thanks! PS: the driver argument should have a |
||
out: Optional[ivy.Array] = None, | ||
) -> ivy.Array: | ||
""" | ||
Return the singular values of a matrix (or a stack of matrices) ``x``. | ||
|
@@ -2273,6 +2277,9 @@ def svdvals( | |
x | ||
input array having shape ``(..., M, N)`` and whose innermost two dimensions form | ||
``MxN`` matrices. | ||
driver | ||
optional output array,name of the cuSOLVER method to be used. This keyword argument only works on CUDA inputs. | ||
Available options are: None, gesvd, gesvdj, and gesvda.Default: None. | ||
out | ||
optional output array, for writing the result to. It must have a shape that the | ||
inputs broadcast to. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
driver: ... = None
required