-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setting sub_backends by default if they are available #25976
feat: setting sub_backends by default if they are available #25976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest checking through the failing tests to see if any of the backend handler tests are related to the change made (which it most probably won't be).
Secondly, that line wouldn't be redundant but I suppose all the changes added in this PR would be (sorry @Madjid-CH 😅), because if a sub-backend wasn't set then it means either it wasn't installed or the user opted out. In either case we shouldn't be throwing the warning as a result of these changes. Could you please also revert those changes? Thanks @ShreyanshBardia 😄
do we have to consider if multiple sub-backends are available or we can ignore that for the moment since we currently only have one sub-backend ? |
Yes realised it later, we still would need to update |
Hey @Madjid-CH, I think the possibility of there being an implementation of multiple sub-backends for the same function is a bit rare, so we're not considering that for now. Basically for all functions if there's a sub-backend implementation it would be used by default on setting that backend if the library was installed. Hope that makes sense 😄 |
Yep I've already reverted those changes, I think the PR is good to merge. Thanks @ShreyanshBardia 😄 |
part of task
With these changes I think this function becomes redundant and should be removed.
@vedpatwardhan