Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontends): Implemented number casting rules to __init__ #26933

Closed
wants to merge 9 commits into from

Conversation

NathanJargon
Copy link

@NathanJargon NathanJargon commented Oct 12, 2023

PR Description

Since the number() function is an abstract base class that represents the numeric scalar types in JAX NumPy, and it is not used directly. I am using specific numeric types from the jax.numpy module, such as jnp.int32 or jnp.float64, rather than calling number() directly.

Related Issue

Closes #26857

Checklist

  • Did you add a function? Kinda.
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Oct 12, 2023
@github-actions
Copy link
Contributor

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@ivy-seed ivy-seed assigned hmahmood24 and unassigned bipinKrishnan Oct 13, 2023
@hmahmood24
Copy link
Contributor

Hey @NathanJargon, thanks a lot for the PR. However, it seems like we're trying to add a class to the frontend which is against our policy i.e. we only add the functional api of frameworks to our frontends and not any high level classes. Since this was an error on our part, I apologise for any inconvenience caused by this. I'll have to unfortunately close this PR and the corresponding issue since this is not needed. But please feel free to contribute on other areas of the codebase. Thanks so much! :)

@hmahmood24 hmahmood24 closed this Oct 16, 2023
@NathanJargon NathanJargon deleted the master branch October 16, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

number
5 participants