-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly set qualification properties #60
Conversation
If not in debug mode, use a simpler EDTFParseException rather than returning the full pyparsing error
Includes handling for empty or null input strings and null errs passed to the constructor Co-Authored-By: aweakley <[email protected]>
Make the string representation of TestEvent simpler
Properly set qualification properties on - UncertainOrApproximate - Unspecified - Level1Interval - PartialUncertainOrApproximate - Level2Interval Adds tests to check that each EDTF object is parsed and that .is_approximate, .is_uncertain, and .is_uncertain_and_approximate are set to what we expect them to be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just made a couple of comments @ColeDCrawford
edtf/parser/parser_classes.py
Outdated
all_ua, | ||
] | ||
self.is_uncertain = any( | ||
item.is_uncertain for item in uas if hasattr(item, "is_approximate") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be is_uncertain
README.md
Outdated
False | ||
|
||
>>> parse_edtf("2004?-~06-~04") | ||
PartialUncertainOrApproximate: '2004?-~06-~04'>>> L2_PartialUncertainOrApproximate.is_approximate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a typo here.
Thank you, this looks great. |
Tackle #31 by setting qualification properties on
This PR also adds tests to check that each EDTF object is parsed and that
.is_approximate
,.is_uncertain
, and.is_uncertain_and_approximate
are set to what we expect them to be. It also adds some documentation about these properties.Branched off of PR #59