Update serde derives. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This reduces the noise in another upcoming PR once this lands which removes most of the remaining |
Since the crate is using Rust edition 2018, we can use the macros directly without a `macro_use`. The recommended way to use `serde_derive` now is to use the `derive` feature on the `serde` crate.
waywardmonkeys
force-pushed
the
modernize-serde
branch
from
2282dcc
to
22beccd
Compare
|
@brettfo Could you take a look at this one, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the crate is using Rust edition 2018, we can use the macros directly without a
macro_use.The recommended way to use
serde_derivenow is to use thederivefeature on theserdecrate.