Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create macro for generating points #60

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

BradenEverson
Copy link
Contributor

Hey! I've been using your dxf crate for an honors project I'm working on for school. I at first created some private macros to make creating points(and drawings from points, but I didn't know how necessary that was to the general public) simpler, and thought I might as well share them here if you found it useful. I decided to write up some docs for the point macro and configure a quick unit test as well, feel free to respond with any feedback you'd like!

If you feel as though the drawing macro(takes in a series of points and returns a closed shape drawing of those points), let me know and I can get another pull request created.

Cheers!

Braden

@BradenEverson BradenEverson changed the title Create point! macro Create macro for generating points Feb 19, 2024
@brettfo
Copy link
Member

brettfo commented Feb 23, 2024

Thank you, this looks like a nice addition!

One of the CI steps does some formatting checks that are failing. You can run the checks locally with cargo fmt --all -- --check or if I remember correctly, you can have the formatter fix them for you with cargo fmt --all.

@BradenEverson
Copy link
Contributor Author

Thank you, this looks like a nice addition!

One of the CI steps does some formatting checks that are failing. You can run the checks locally with cargo fmt --all -- --check or if I remember correctly, you can have the formatter fix them for you with cargo fmt --all.

Sonds good! I'll get that fixed up right away

@brettfo brettfo merged commit c9b6f59 into ixmilia:main Feb 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants