Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New development from our side #25

Open
wants to merge 152 commits into
base: 1.1
Choose a base branch
from

Conversation

tis-dm-webfactory
Copy link
Contributor

Hi,

we (actually it was me in my free time) further extended the command scheduler.
It now supports restrictions to users and hosts, logging of executions (and return codes) to the database, cleanup of stored logs, executions history, "human readable" monitoring, ...

I changed the translation management to json - for me it was much easier to keep track of new translations in a "small" json file instead of a much more "complex" xml. Speaking of translations - nobody here speaks french good enough to translate the new texts, so these are still english.

We've also included your changes from our last PR ;-)

here you find the results of my last build:
https://insight.sensiolabs.com/projects/f0991948-dd04-4f4d-a6a4-1a348d1ceb57
https://travis-ci.org/homerjsimpson000/CommandSchedulerBundle
https://coveralls.io/github/homerjsimpson000/CommandSchedulerBundle?branch=master

we still are stuck to php 5.3.something, so I implemeted everything that it works with 5.3 as well as 7...

I hope, you like the extensions we've added

greetings from Tyrol/Austria

daniel added 30 commits November 15, 2015 15:27
…s to json (new translations are missing - i don't speak french at all)
… added translations, added helper for cronexpressions
@j-guyon j-guyon added this to the 1.3.0 milestone Mar 16, 2016
@j-guyon j-guyon self-assigned this Mar 16, 2016
tis-dm-webfactory and others added 4 commits May 31, 2016 14:24
increased memory_limit
changed default ordering
try to speed up command list
@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 90.873% when pulling 3c8b469 on tis-dm-webfactory:master into f752499 on J-Mose:1.1.

@coveralls
Copy link

coveralls commented Apr 12, 2017

Coverage Status

Coverage increased (+1.2%) to 90.882% when pulling 175750f on tis-dm-webfactory:master into f752499 on J-Mose:1.1.

@chrisjohnson00
Copy link
Contributor

chrisjohnson00 commented Apr 26, 2017

i like some of the concepts here, however i think this is too large of a PR. IMO it should be broken into parts like: translation refactoring, execution logging, etc.
Some of the items (cleaning up logs), I for one don't think should be part of the bundle as logrotate is commonly used for this task.

Logrotate config from one of my project vagrants (no code to support/test!!):

/vagrant/var/logs/*.log {
    daily
    missingok
    rotate 3
    compress
    delaycompress
    notifempty
    create 640 vagrant vagrant
    su vagrant vagrant
}

I was thinking of forking the project to implement execution logging, so maybe i'll just cherry pick your commits and make a smaller PR.

Copy link
Contributor

@chrisjohnson00 chrisjohnson00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( another one bites the dust.
What was this bundle replaced with in your architecture?

There's a spelling mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants