-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New development from our side #25
base: 1.1
Are you sure you want to change the base?
Conversation
…ng.yml; TODO: actions for requirements
…ng translations to json
…s to json (new translations are missing - i don't speak french at all)
… added translations, added helper for cronexpressions
…command to rights
…nds with rights doesnt't work right now.
sensiolab badge in readme
sensiolabs config
sensiolabs config
travis green, about to test in productive environment
minor update to get a username
added fallback for old ".../list" route
update date filter in tables
increased memory_limit
changed default ordering
try to speed up command list
i like some of the concepts here, however i think this is too large of a PR. IMO it should be broken into parts like: translation refactoring, execution logging, etc. Logrotate config from one of my project vagrants (no code to support/test!!):
I was thinking of forking the project to implement execution logging, so maybe i'll just cherry pick your commits and make a smaller PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:( another one bites the dust.
What was this bundle replaced with in your architecture?
There's a spelling mistake.
Hi,
we (actually it was me in my free time) further extended the command scheduler.
It now supports restrictions to users and hosts, logging of executions (and return codes) to the database, cleanup of stored logs, executions history, "human readable" monitoring, ...
I changed the translation management to json - for me it was much easier to keep track of new translations in a "small" json file instead of a much more "complex" xml. Speaking of translations - nobody here speaks french good enough to translate the new texts, so these are still english.
We've also included your changes from our last PR ;-)
here you find the results of my last build:
https://insight.sensiolabs.com/projects/f0991948-dd04-4f4d-a6a4-1a348d1ceb57
https://travis-ci.org/homerjsimpson000/CommandSchedulerBundle
https://coveralls.io/github/homerjsimpson000/CommandSchedulerBundle?branch=master
we still are stuck to php 5.3.something, so I implemeted everything that it works with 5.3 as well as 7...
I hope, you like the extensions we've added
greetings from Tyrol/Austria