Frontend errors #94

Aito0 · 2025-02-20T13:59:51Z

Implemented dill exception structure and popup displaying

….scala

This reverts commit 27afb01.

This reverts commit a45520a.

…ning

aniket1101

i dont like this

AdamW1087 · 2025-02-21T14:32:27Z

frontend/src/main/scala/Main.scala

+
+val root: HtmlElement = div(
+    MainView(),
+    ErrorController.displayError


Maybe add a "," on the end, we do it for other places

AdamW1087 · 2025-02-21T14:33:04Z

frontend/src/main/scala/Main.scala

+val root: HtmlElement = div(
+    MainView(),
+    ErrorController.displayError
+)


also maybe put root above main? It looks off calling something that is defined below

AdamW1087 · 2025-02-21T14:33:25Z

frontend/src/main/scala/controller/DebugTreeController.scala

        }
    }

    /**
      * Decode a JSON string into a list of DebugNodes.
      *
      * @param jsonString The JSON string to convert.
-      * 
+      *  


whitespace addition :(

AdamW1087 · 2025-02-21T14:34:19Z

frontend/src/main/scala/controller/DebugTreeController.scala

+}
+
+object MalformedJSONException extends Exception


Should this be at the bottom, would it be more suitable near the top?

AdamW1087 · 2025-02-21T14:34:44Z

frontend/src/main/scala/controller/ErrorController.scala

+  * ErrorController keeps track of the error state of the app and the code to display error 
+  * popups in the app 


balance these lines a bit more its really top heavy

AdamW1087 · 2025-02-21T14:39:31Z

frontend/src/main/scala/controller/viewControllers/InputViewController.scala

+         setInput (
+            h1(
+                className := "debug-tree-title",
+                p("Parser Input : ", margin.px := 0, fontSize.px := 15,


Make css obj for the text?

AdamW1087 · 2025-02-21T14:39:49Z

frontend/src/main/scala/controller/viewControllers/MainViewController.scala

@@ -24,6 +30,8 @@ object MainViewController {
    def getMainView: Signal[HtmlElement] = 
        isTreeView.signal.map(if (_) then TreeView() else InputView())

+    def getNoTreeFound: HtmlElement = noTreeFound


AdamW1087 · 2025-02-21T14:41:46Z

frontend/src/main/scala/model/DillException.scala

+    def displayElement: HtmlElement = {
+        div(
+            className := "popup",
+            cls := style,
+            h2(
+                this.name,
+                color := "#ffffff",
+            ),
+            br(),
+            div(
+                className := "popup-text",
+                this.message,
+            ),
+            if closable then onClick --> {_ => ErrorController.clearError()} else onClick --> {_ => ()}
+        )
+    }
+}


brace not needed

AdamW1087 · 2025-02-21T14:42:46Z

frontend/src/main/scala/view/TreeView.scala

-    def apply(): HtmlElement = div(
-        TreeViewController.getDisplayTree, /* Renders the tree */
-    )
+    def apply(): HtmlElement = 
+        div(
+            TreeViewController.getDisplayTree   /* Renders the tree */
+        )


AdamW1087 · 2025-02-21T14:43:08Z

styles.css

@@ -16,6 +17,7 @@
    --font-color-primary: #96DEC4;	        /* Parsley green. */
    --font-color-secondary: #242526;	    /* Dark grey. */
    --font-color-error: #d2042d;	        /* Red error. */
+    --font-color-warning: #ffcc00;	        /* Yelow warning colour. */


Yellow typo

riley ahh yelow

josh-ja-walker · 2025-02-21T14:46:44Z

frontend/src/main/scala/Main.scala

+val root: HtmlElement = div(
+    MainView(),
+    ErrorController.displayError


Move to MainView

josh-ja-walker · 2025-02-21T14:49:14Z

frontend/src/main/scala/controller/viewControllers/InputViewController.scala

+     * @param input The input string
+     */
+    def toInputElement(input: String): Unit =
+         setInput (


josh-ja-walker · 2025-02-21T14:49:56Z

frontend/src/main/scala/model/DillException.scala

+    override def colour: String = "ffff00"
+    override def closable: Boolean = true
+    override def style: String = "warning"
+}
+
+/**
+  * Represents a breaking Exception in Dill. Overrides colour to red and canDelete to false
+  */
+sealed trait Error extends DillException {
+    override def colour: String = "ff0000"
+    override def closable: Boolean = false
+    override def style: String = "error"
+}


colour is set in css

so remove this

josh-ja-walker · 2025-02-21T14:51:44Z

frontend/src/main/scala/model/DillException.scala

+}
+
+/* Used when an unexpected error occurs */
+case class UnknownError(mes: String) extends Error {


msg instead of mes

please dont ignore this

josh-ja-walker · 2025-02-21T14:52:06Z

styles.css

@@ -16,6 +17,7 @@
    --font-color-primary: #96DEC4;	        /* Parsley green. */
    --font-color-secondary: #242526;	    /* Dark grey. */
    --font-color-error: #d2042d;	        /* Red error. */
+    --font-color-warning: #ffcc00;	        /* Yelow warning colour. */


riley ahh yelow

AdamW1087 · 2025-02-21T15:10:01Z

styles.css

@@ -16,6 +17,7 @@
    --font-color-primary: #96DEC4;	        /* Parsley green. */
    --font-color-secondary: #242526;	    /* Dark grey. */


dark grey comment not lined up with the others

still not lined up

AdamW1087 · 2025-02-21T15:23:24Z

frontend/src/main/scala/controller/DebugTreeController.scala

@@ -14,27 +19,26 @@ object DebugTreeController {
      * Decode a JSON string into a DebugTree class.
      *
      * @param jsonString The JSON string to convert.
-      * 


please bring back :(

AdamW1087 · 2025-02-21T15:25:00Z

frontend/src/main/scala/model/DillException.scala

+        "Failed to serialize the display tree. " +
+        "This may indicate an issue with the serialization process. " +
+        "Please report this issue to Jamie Willis if the problem persists"
+}


NOT TO JAMIE

AdamW1087 · 2025-02-21T15:25:10Z

frontend/src/main/scala/model/DillException.scala

+}
+
+/* Used when an unexpected error occurs */
+case class UnknownError(mes: String) extends Error {


please dont ignore this

AdamW1087 · 2025-02-21T15:25:34Z

styles.css

@@ -16,6 +17,7 @@
    --font-color-primary: #96DEC4;	        /* Parsley green. */
    --font-color-secondary: #242526;	    /* Dark grey. */


still not lined up

josh-ja-walker and others added 27 commits February 12, 2025 14:27

feat(TreeController): Handle failed Tauri Invoke Future

7c78eb7

feat: added error handling in frontend

ec4aac7

feat: Added error popup

651bd5d

feat: Added error message per error type

1a8471f

feat: Implemented error OOP hierarchy

1e81bbd

style: Remove test.scala

5b07495

style: Rename test.scala

4cfcb99

fix: Fixed compile error in DillException.scala

cca5982

refactor: Refactored error OOP structure

f0245c5

fix: Fixed rendering of empty errors and refactored displaying code

cd24859

docs: Added scaladoc comments to DillException.scala and ErrorHandler…

bdd8226

….scala

feat: Started mapError function in ErrorHandler.scala

8f1e02a

feat: Implemented matching backend error to frontend error objetcs

44438db

refactor: Made an errors folder in view

27afb01

refactor: Moved error popup styling to its own file

a45520a

Revert "refactor: Made an errors folder in view"

97bae6c

This reverts commit 27afb01.

Revert "refactor: Moved error popup styling to its own file"

0a495ef

This reverts commit a45520a.

fix: Added back deleted files

6444f46

feat: Changed border colour depending on wether it is an error or war…

ce43f45

…ning

fix: Improved error messages

13b5c9b

fix: Fixed display bug

b1610cb

Merge branch 'dev' into frontend-errors

cba0c9c

feat: Improved error popup style

f4e3975

Merge branch 'dev' into frontend-errors

0fc54b3

refactor: Moved no tree found message to MainViewController

734f721

refactor: Moved input element HtmlElement to InputController

2795043

fix: Changed MalformedJSON to Error

fe10b7d

Aito0 requested review from aniket1101 and josh-ja-walker and removed request for aniket1101 February 20, 2025 14:00

Aito0 requested a review from AdamW1087 February 20, 2025 14:00

aniket1101 requested changes Feb 20, 2025

View reviewed changes

aniket1101 self-requested a review February 20, 2025 20:30

Aito0 removed the request for review from aniket1101 February 21, 2025 14:17

AdamW1087 requested changes Feb 21, 2025

View reviewed changes

josh-ja-walker requested changes Feb 21, 2025

View reviewed changes

Alejandro Perez Fadon added 2 commits February 21, 2025 15:01

style: Fixed style in frontend

753d681

refactor: Added styling to separate css in InputViewController

07eaf35

AdamW1087 requested changes Feb 21, 2025

View reviewed changes

fix: Fixed compiler error and style in input view

117234c

AdamW1087 requested changes Feb 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Frontend errors #94

Frontend errors #94

Aito0 commented Feb 20, 2025

aniket1101 left a comment

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

josh-ja-walker Feb 21, 2025

josh-ja-walker Feb 21, 2025

josh-ja-walker Feb 21, 2025

josh-ja-walker Feb 21, 2025

josh-ja-walker Feb 21, 2025

josh-ja-walker Feb 21, 2025

AdamW1087 Feb 21, 2025

josh-ja-walker Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

AdamW1087 Feb 21, 2025

		* ErrorController keeps track of the error state of the app and the code to display error
		* popups in the app

		@@ -16,6 +17,7 @@
		--font-color-primary: #96DEC4; /* Parsley green. */
		--font-color-secondary: #242526; /* Dark grey. */

Frontend errors #94

Are you sure you want to change the base?

Frontend errors #94

Conversation

Aito0 commented Feb 20, 2025

aniket1101 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment