Skip to content

Materials: new material definitions for common shaders #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025

Conversation

capdevon
Copy link
Contributor

Provides a material definition that visualizes the mesh normals, useful for debugging geometry and lighting issues.

@yaRnMcDonuts yaRnMcDonuts added this to the v3.9.0 milestone Jun 12, 2025
@yaRnMcDonuts
Copy link
Member

yaRnMcDonuts commented Jun 12, 2025

I'm not sure if the original author intended to only include only the primary stock 3 shaders here (pbr, lighting, and unshaded) but I don't see any reason that more shaders shouldn't be added for convenience. It also serves as a good list of available shaders for anyone who looks at this class and may see one they didn't know existed.

So unless anyone else has issue with adding to this list, then I'd say it looks good to me.

I'd also even say it would be beneficial to add some more (like the particle shader, thats one that I constantly find myself retyping or copy/pasting everytime I make a new ParticleEmitter), but that can always be done later or by someone else if you prefer to keep the scope of this PR limited.

@capdevon
Copy link
Contributor Author

capdevon commented Jun 12, 2025

Hi @yaRnMcDonuts ,
Adding the ParticleEmitter shader to the list also seems like a good idea!
I'll add it to the PR and edit the title.

@capdevon capdevon changed the title Materials: Add SHOW_NORMALS Material Definition Materials: new material definitions for common shaders Jun 12, 2025
@yaRnMcDonuts
Copy link
Member

I was going to merge this right now

But I'll leave it open for a little while just in case there's any more you want to add to the list. Otherwise let me know when you think its ready and then I'll merge.

@capdevon
Copy link
Contributor Author

capdevon commented Jun 17, 2025

Hi @yaRnMcDonuts , I think the PR is now complete and ready to be merged.

@yaRnMcDonuts yaRnMcDonuts merged commit 8751505 into jMonkeyEngine:master Jun 17, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants