feat: handle limited time key, Lua function for obtaining keys #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Handle key timeout fix: missing data in handling stream data
rameshsanth
changed the title
jackMort
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 3 items.
Lua function is self explanatory. The README has been updated to reflect it and also with an example that I'm using personally. The change is simple also. It is a 2 line change in loadConfigFromCommand()
The timeout handling is bit complicated. Every time the ChatGPT API's is used, the key is validated before executing the command. To achieve this, some code had to be refactored.
The third one is shown by below two screen shots with and without the fix.
Without the fix.
With the fix.
