File manager #59
Open
File manager #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uses a runtime malloc error
… within a CompositeBinnedNLLH object. Have tested the mapping for a number of scenarios and it seems to work.
parameters is constrained between two different data fits.
Fix to Scale systematic.
Conflicts: src/SConscript
…ToBinnedED Conflicts: src/fitutil/BinnedEDManager.cpp
…ileManager Conflicts: src/dist/BinnedED.cpp src/dist/BinnedED.h
|
I like this idea, let me know when you want me to take a look over it |
Add a check to the `Minuit` initialisation to look for minima that are equal to or greater than the corresponding maximum. Before this, minuit fails an assert with a half decent error message. Now throws `LogicError` instead
`Minuit` initialisation check
…eMatrix. For testing.
…tting and setting
Adding functionality to access the covariance matrix from Minuit
* Swap of JumpPDF integration limits * Catch.
Delete the original `PDF` inside `Convolution` before replacing it with a new one (the pointer is initialised to `NULL` and `NULL` deletion is OK so no further checks should be needed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to show the FileManager I have been working on. It seems to work but is still a work in progress. I have not been able to test the test yet.
I don't know why the examples/simpleFit.cpp or the config/buildhelp.py are different I thought these were merged.