Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce reverse colors and show legend options #4

Merged
merged 6 commits into from
May 10, 2024
Merged

Introduce reverse colors and show legend options #4

merged 6 commits into from
May 10, 2024

Conversation

jackw
Copy link
Owner

@jackw jackw commented May 10, 2024 •
edited
Loading

Features 🌟

  • Reverse Colors - reverse the order of colors in the traffic lights.
  • Show Legend - render the legend / query name separate to the value and trend.

Tests 🧪

  • Replace duplicated test id strings with TEST_IDS const.
  • Update to plugin-e2e 1.x.x.
  • Add tests for rendering TrafficLightValue component.

fixes: #3

@jackw jackw added the enhancement New feature or request label May 10, 2024
@jackw jackw self-assigned this May 10, 2024
@jackw jackw changed the title Jackw/new features Introduce reverse colors and show legend options May 10, 2024
@jackw jackw merged commit 3685ce2 into main May 10, 2024
1 check passed
@jackw jackw deleted the jackw/new-features branch May 10, 2024 14:00
@fgrandel
Copy link

Thanks, @jackw , for implementing this feature! Highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackw jackw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wishlist: Option to reverse traffic light colors (aka thresholds)
2 participants
@jackw @fgrandel