add double line as default border #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the default is going to change, I'd prefer to do one release that keeps single as the default, with a warning that the default is going to change to double in a future release. |
|
I changed the default to single line and added a warning that the default would change in future releases. |
| table_type == :latex && return "\\bottomrule\n\\end{tabular}" | ||
| elseif border == :none | ||
| table_type == :latex && return "\\bottomrule\n\\end{tabular}" | ||
| @warn("default border will change to double in future releases") |
There was a problem hiding this comment.
You're missing an end statement here. That's why the travis builds are failing.
In general, you can catch some of these mistakes locally by running ] test TexTables on your machine. All of the tests should pass before we merge this pr.
There was a problem hiding this comment.
I fixed the error and ran the build on my local machine as you suggested. The tests all passed locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #6 to add a default option
border :doublefor latex table borders\hline\hline. I made this the default option, but I also included aborder :singleoption to allow the user to keep\toprule' and\bottomrule' if they want.I ran runtests.jl and there were no errors.
Let me know if there is anything I need to fix or tests that I should create.