Add flake.nix #15
Open
Add flake.nix #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
reviewed
Aug 31, 2024
flake.nix
Outdated
Comment on lines
23
to
48
| name = binName; | ||
| src = ./.; | ||
|
|
||
| buildInputs = with pkgs; [ | ||
| cairo | ||
| cmake | ||
| meson | ||
| ninja | ||
| pkg-config | ||
| ]; | ||
|
|
||
| configurePhase = '' | ||
| meson build | ||
| ''; | ||
|
|
||
| buildPhase = '' | ||
| ( | ||
| cd build | ||
| meson compile | ||
| ) | ||
| ''; | ||
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| cp build/src/${binName} $out/bin | ||
| ''; |
There was a problem hiding this comment.
Don't use name use pname.
There's build time tools in buildInputs.
The phases are unneeded because of meson's hook. (after #16)
It would make more sense to override the stdenv to clang and overrideAttrs the src of the package from nixpkgs.
There was a problem hiding this comment.
Thanks for the feedback. I've switched to pname and nativeBuildInputs.
I'm a flake noob. Could you elaborate on the override suggestion or point me to an example? Are you suggesting I override from an existing package in nixpkgs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flake.nix file so the repo can be built and run with nix.
I added this to my fork in order to include it in my nix config--submitting a PR in case it is useful to anyone else.