Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add novalidate attribute to form create helper #1404

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

Stanton
Copy link
Member

@Stanton Stanton commented Jul 7, 2021

This change adds novalidate to the list of default attributes supplied by the form.create helper.

This allows products to fall back to server-side validation as per accessibility guidelines.

@Stanton Stanton requested a review from jamesjacobs July 7, 2021 09:07
@Stanton Stanton self-assigned this Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #1404 (5c52330) into develop (88f17e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1404   +/-   ##
==========================================
  Coverage      96.27%   96.27%           
  Complexity        95       95           
==========================================
  Files             65       65           
  Lines           2580     2580           
==========================================
  Hits            2484     2484           
  Misses            96       96           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f17e8...5c52330. Read the comment docs.

@Stanton
Copy link
Member Author

Stanton commented Dec 6, 2022

@jamesjacobs Do we still want this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant