Improve obviousness of responsive datatable expand/collapse control #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attempts to address a usability concern regarding the collapsing datatables control to increase obviousness and visibility. Commonly, expand controls are positioned at the right hand edge of applicable components, and a caret icon is commonly associated with elements that expand or 'drop down'
theGreener
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address a usability concern regarding the collapsing datatables control to increase obviousness and visibility.
Commonly, expand controls are positioned at the right hand edge of applicable components, and a caret icon is commonly associated with elements that expand or 'drop down'.
Before
After
This won't be a seamless change, products typically implement their own datatable initialisation code so this would likely be a breaking change if products are using the html.datatable helper in conjunction with their own javascript.
In practice, I can't see that Central or Connect use html.datatable, so this change will need to be applied to relevant instances of collapsing datatables in product and their associated js.