Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kafka exporter and receiver configuration #5703

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joeyyy09
Copy link
Contributor

@joeyyy09 joeyyy09 commented Jul 3, 2024

Which problem is this PR solving?

Description of the changes

  • Create collector-with-kafka.yaml and ingester.yaml

How was this change tested?

Checklist

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (bbd863f) to head (f02e2fc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5703   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         334      334           
  Lines       16144    16144           
=======================================
  Hits        15563    15563           
  Misses        404      404           
  Partials      177      177           
Flag Coverage Δ
badger_v1 8.06% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-3.x-v1 16.63% <ø> (ø)
cassandra-3.x-v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.63% <ø> (ø)
cassandra-4.x-v2 1.82% <ø> (ø)
elasticsearch-7.x-v1 18.85% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.06% <ø> (ø)
elasticsearch-8.x-v2 19.04% <ø> (-0.02%) ⬇️
grpc_v1 9.46% <ø> (ø)
grpc_v2 7.41% <ø> (ø)
kafka 9.75% <ø> (ø)
opensearch-1.x-v1 18.91% <ø> (ø)
opensearch-2.x-v1 18.91% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 18.90% <ø> (-0.02%) ⬇️
unittests 94.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but we need e2e tests

@yurishkuro yurishkuro added storage/kafka v2 changelog:exprimental Change to an experimental part of the code labels Jul 3, 2024
@joeyyy09
Copy link
Contributor Author

joeyyy09 commented Jul 4, 2024

Lgtm, but we need e2e tests

Yeah, will get started on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code storage/kafka v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Jaeger v2] Add Kafka exporter and receiver
2 participants