Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for hotrod on k8s #6088

Closed
wants to merge 13 commits into from

Conversation

chahatsagarmain
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

@chahatsagarmain chahatsagarmain requested a review from a team as a code owner October 14, 2024 20:54
@chahatsagarmain chahatsagarmain marked this pull request as draft October 14, 2024 20:54
@chahatsagarmain
Copy link
Contributor Author

@yurishkuro can you have a look at the script and how should i use it in the workflow ?

@chahatsagarmain chahatsagarmain marked this pull request as ready for review October 15, 2024 21:17
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (4688cc0) to head (4281bf5).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6088      +/-   ##
==========================================
- Coverage   96.92%   96.45%   -0.48%     
==========================================
  Files         351      352       +1     
  Lines       16675    19986    +3311     
==========================================
+ Hits        16162    19277    +3115     
- Misses        329      524     +195     
- Partials      184      185       +1     
Flag Coverage Δ
badger_v1 8.42% <ø> (+0.43%) ⬆️
badger_v2 1.70% <ø> (-0.14%) ⬇️
cassandra-4.x-v1 14.57% <ø> (-1.19%) ⬇️
cassandra-4.x-v2 1.64% <ø> (-0.13%) ⬇️
cassandra-5.x-v1 14.57% <ø> (-1.19%) ⬇️
cassandra-5.x-v2 1.64% <ø> (-0.13%) ⬇️
elasticsearch-6.x-v1 18.72% <ø> (-0.22%) ⬇️
elasticsearch-7.x-v1 18.81% <ø> (-0.20%) ⬇️
elasticsearch-8.x-v1 18.98% <ø> (-0.22%) ⬇️
elasticsearch-8.x-v2 1.69% <ø> (-0.15%) ⬇️
grpc_v1 8.77% <ø> (-0.58%) ⬇️
grpc_v2 6.72% <ø> (-0.41%) ⬇️
kafka-v1 8.99% <ø> (-0.70%) ⬇️
kafka-v2 1.70% <ø> (-0.14%) ⬇️
memory_v2 1.69% <ø> (-0.15%) ⬇️
opensearch-1.x-v1 18.86% <ø> (?)
opensearch-2.x-v1 18.86% <ø> (-0.19%) ⬇️
opensearch-2.x-v2 1.69% <ø> (-0.14%) ⬇️
tailsampling-processor 0.48% <ø> (-0.01%) ⬇️
unittests 95.37% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid unnecessary changes. For example, why did the flag parsing moved from the top of the file (where it is customary located in all our scripts) into the main()? If you wanted to wrap it in a function, you could do it without physically moving the code and creating a disassociated code diff.

Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
@chahatsagarmain
Copy link
Contributor Author

@yurishkuro i have made some changes please have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants