Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6429 : Reorganize scripts/build folder #6433

Closed
wants to merge 3 commits into from

Conversation

Ashu463
Copy link

@Ashu463 Ashu463 commented Dec 28, 2024

Which problem is this PR solving?

Description of the changes

  • In this PR all scripts of build category moved to build/ folder.

How was this change tested?

  • Attaching screenshot :
    image

Checklist

@Ashu463 Ashu463 requested a review from a team as a code owner December 28, 2024 03:45
@Ashu463 Ashu463 requested a review from jkowall December 28, 2024 03:45
@lekaf974
Copy link
Contributor

lekaf974 commented Dec 28, 2024

@Ashu463 you need to amend your PR and signoff to fix DCO error

Also did you update the files that were calling those scripts ?

@Ashu463 Ashu463 changed the title scriipts moved to build dir within that Fixes #6429 : Reorganize scripts/build folder Dec 28, 2024
@Ashu463
Copy link
Author

Ashu463 commented Dec 28, 2024

@Ashu463 you need to amend your PR and signoff to fix DCO error

Also did you update the files that were calling those scripts ?

Hey @lekaf974 how would I do the same, could you help me ?

@yurishkuro
Copy link
Member

See CONTRIBUTING_GUIDELINES.md for DCO check

@lekaf974
Copy link
Contributor

you could try git commit --amend --signoff

@lekaf974
Copy link
Contributor

@Ashu463 you also need to update files referring to those scripts

@Ashu463
Copy link
Author

Ashu463 commented Dec 29, 2024

@lekaf974 what files am I supposed to update ? as per the description I just have to manage folder structure of scripts/

@yurishkuro
Copy link
Member

as per the description I just have to manage folder structure of scripts/

This is not what the description says. If this was just a matter of moving the files I would not have opened the issue. Moving the scripts breaks the other scripts than depend on them, so the references to the moved files need to be updated. I closed all other PRs until at least one is actually done right, to remove noise and distraction.

@Ashu463
Copy link
Author

Ashu463 commented Dec 30, 2024

Ah you were asking in that way, will fix this soon. It all seems fine while running tests, but if there any other way to test out repository then please let me know.
Thanks !

@yurishkuro
Copy link
Member

if there any other way to test out repository then please let me know.

all integration tests are invoked from .github/workflows, you can see how it's done (there isn't a single command for that).

@yurishkuro
Copy link
Member

@Ashu463 you don't need to run all CI tests locally to solve this issue - you can simply grep the repository for the file names of the scripts, and replace all occurrences. Then once you submit a PR we will run full CI to validate that nothing was misssed.

@lekaf974
Copy link
Contributor

@Ashu463 I can raise a PR for this build folder then you could take it as example for the other one ?

@yurishkuro
Copy link
Member

solved in #6446

@yurishkuro yurishkuro closed this Dec 31, 2024
@Ashu463
Copy link
Author

Ashu463 commented Dec 31, 2024

@yurishkuro good to see this. Is he raised for other ones ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize scripts/ folder
3 participants