-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #6429 : Reorganize scripts/build folder #6433
Conversation
@Ashu463 you need to amend your PR and signoff to fix DCO error Also did you update the files that were calling those scripts ? |
See CONTRIBUTING_GUIDELINES.md for DCO check |
you could try |
Signed-off-by: Ashu463 <[email protected]>
e178cf8
to
2bf6843
Compare
@Ashu463 you also need to update files referring to those scripts |
@lekaf974 what files am I supposed to update ? as per the description I just have to manage folder structure of |
This is not what the description says. If this was just a matter of moving the files I would not have opened the issue. Moving the scripts breaks the other scripts than depend on them, so the references to the moved files need to be updated. I closed all other PRs until at least one is actually done right, to remove noise and distraction. |
Ah you were asking in that way, will fix this soon. It all seems fine while running |
all integration tests are invoked from .github/workflows, you can see how it's done (there isn't a single command for that). |
@Ashu463 you don't need to run all CI tests locally to solve this issue - you can simply grep the repository for the file names of the scripts, and replace all occurrences. Then once you submit a PR we will run full CI to validate that nothing was misssed. |
@Ashu463 I can raise a PR for this build folder then you could take it as example for the other one ? |
solved in #6446 |
@yurishkuro good to see this. Is he raised for other ones ? |
Which problem is this PR solving?
Description of the changes
build/
folder.How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test