Move e2e scripts to scripts/e2e #6448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danish9039 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6448 +/- ##
=======================================
Coverage 96.30% 96.30%
=======================================
Files 371 371
Lines 21160 21160
=======================================
Hits 20379 20379
Misses 598 598
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:ci
yurishkuro
reviewed
Dec 31, 2024
| @@ -45,7 +45,7 @@ jobs: | |||
|
|
|||
| - name: Run cassandra integration tests | |||
| id: test-execution | |||
| run: bash scripts/cassandra-integration-test.sh ${{ matrix.version.major }} ${{ matrix.version.schema }} ${{ matrix.jaeger-version }} | |||
| run: bash scripts/e2e/cassandra-integration-test.sh ${{ matrix.version.major }} ${{ matrix.version.schema }} ${{ matrix.jaeger-version }} | |||
There was a problem hiding this comment.
Suggested change
| run: bash scripts/e2e/cassandra-integration-test.sh ${{ matrix.version.major }} ${{ matrix.version.schema }} ${{ matrix.jaeger-version }} | |
| run: bash scripts/e2e/cassandra.sh ${{ matrix.version.major }} ${{ matrix.version.schema }} ${{ matrix.jaeger-version }} |
please use names provided in the issue
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
yurishkuro
reviewed
Dec 31, 2024
| @@ -57,7 +57,7 @@ jobs: | |||
| - uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf # v3.2.0 | |||
| - name: Run ${{ matrix.version.distribution }} integration tests | |||
| id: test-execution | |||
| run: bash scripts/es-integration-test.sh ${{ matrix.version.distribution }} ${{ matrix.version.major }} ${{ matrix.version.jaeger }} | |||
| run: bash scripts/e2e/es-integration-test.sh ${{ matrix.version.distribution }} ${{ matrix.version.major }} ${{ matrix.version.jaeger }} | |||
There was a problem hiding this comment.
Suggested change
| run: bash scripts/e2e/es-integration-test.sh ${{ matrix.version.distribution }} ${{ matrix.version.major }} ${{ matrix.version.jaeger }} | |
| run: bash scripts/e2e/elasticsearch.sh ${{ matrix.version.distribution }} ${{ matrix.version.major }} ${{ matrix.version.jaeger }} |
.github/workflows/ci-e2e-kafka.yml
Outdated
| @@ -34,7 +34,7 @@ jobs: | |||
|
|
|||
| - name: Run kafka integration tests | |||
| id: test-execution | |||
| run: bash scripts/kafka-integration-test.sh -j ${{ matrix.jaeger-version }} -v ${{ matrix.kafka-version }} | |||
| run: bash scripts/e2e/kafka-integration-test.sh -j ${{ matrix.jaeger-version }} -v ${{ matrix.kafka-version }} | |||
There was a problem hiding this comment.
Suggested change
| run: bash scripts/e2e/kafka-integration-test.sh -j ${{ matrix.jaeger-version }} -v ${{ matrix.kafka-version }} | |
| run: bash scripts/e2e/kafka.sh -j ${{ matrix.jaeger-version }} -v ${{ matrix.kafka-version }} |
.github/workflows/ci-e2e-spm.yml
Outdated
| @@ -49,4 +49,4 @@ jobs: | |||
| uses: ./.github/actions/setup-node.js | |||
|
|
|||
| - name: Run SPM Test | |||
| run: bash scripts/spm-integration-test.sh -b ${{ matrix.mode.binary }} | |||
| run: bash scripts/e2e/spm-integration-test.sh -b ${{ matrix.mode.binary }} | |||
There was a problem hiding this comment.
Suggested change
| run: bash scripts/e2e/spm-integration-test.sh -b ${{ matrix.mode.binary }} | |
| run: bash scripts/e2e/spm.sh -b ${{ matrix.mode.binary }} |
Signed-off-by: danish9039 <[email protected]>
yurishkuro
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
part of
Description of the changes