Create a /quality-metrics endpoint #6608

ADI-ROXX · 2025-01-25T16:34:24Z

Which problem is this PR solving?

Resolves Create dummy /quality-metrics endpoint #6607
Related to [Feature]: Make changes to allow for /api/quality-metrics to work jaeger-ui#2640

Description of the changes

How was this change tested?

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: npm run lint and npm run test

Signed-off-by: cs-308-2023 <[email protected]>

codecov · 2025-01-25T16:45:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (bc2a643) to head (8d5df2d).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6608      +/-   ##
==========================================
+ Coverage   95.99%   96.03%   +0.04%     
==========================================
  Files         363      364       +1     
  Lines       20601    20696      +95     
==========================================
+ Hits        19775    19876     +101     
+ Misses        630      626       -4     
+ Partials      196      194       -2

Flag	Coverage Δ
badger_v1	`9.88% <ø> (+0.05%)`	⬆️
badger_v2	`1.81% <ø> (-0.01%)`	⬇️
cassandra-4.x-v1-manual	`14.83% <ø> (+0.04%)`	⬆️
cassandra-4.x-v2-auto	`1.80% <ø> (-0.01%)`	⬇️
cassandra-4.x-v2-manual	`1.80% <ø> (-0.01%)`	⬇️
cassandra-5.x-v1-manual	`14.83% <ø> (+0.04%)`	⬆️
cassandra-5.x-v2-auto	`1.80% <ø> (-0.01%)`	⬇️
cassandra-5.x-v2-manual	`1.80% <ø> (-0.01%)`	⬇️
elasticsearch-6.x-v1	`19.16% <ø> (+0.03%)`	⬆️
elasticsearch-7.x-v1	`19.24% <ø> (+0.03%)`	⬆️
elasticsearch-8.x-v1	`19.41% <ø> (+0.03%)`	⬆️
elasticsearch-8.x-v2	`1.81% <ø> (-0.01%)`	⬇️
grpc_v1	`10.85% <ø> (+0.05%)`	⬆️
grpc_v2	`7.78% <ø> (-0.04%)`	⬇️
kafka-3.x-v1	`10.17% <ø> (+0.05%)`	⬆️
kafka-3.x-v2	`1.81% <ø> (-0.01%)`	⬇️
memory_v2	`1.81% <ø> (-0.01%)`	⬇️
opensearch-1.x-v1	`19.29% <ø> (+0.03%)`	⬆️
opensearch-2.x-v1	`19.29% <ø> (+0.03%)`	⬆️
opensearch-2.x-v2	`1.81% <ø> (-0.01%)`	⬇️
tailsampling-processor	`0.48% <ø> (-0.01%)`	⬇️
unittests	`94.92% <100.00%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/query/app/http_handler.go

yurishkuro

include a screenshot demonstrating that this works in the UI

Signed-off-by: cs-308-2023 <[email protected]>

yaten2302 · 2025-01-30T18:42:29Z

Hey @ADI-ROXX , I was working on this PR: Migrate DetailsCard from class based to function based component, but there's a problem that before migrating, the /quality-metrics endpoint must be present in order to show the correct results.
I see that you're working on this issue, may we collaborate on this, if it's fine with you?
Thanks

yurishkuro · 2025-01-30T22:25:40Z

cmd/query/app/http_handler.go

@@ -183,7 +262,7 @@ func (aH *APIHandler) transformOTLP(w http.ResponseWriter, r *http.Request) {
 	}

 	traces, err := otlp2traces(body)
-	if aH.handleError(w, err, http.StatusInternalServerError) {
+	if aH.handleError(w, err, http.StatusBadRequest) {


this is unrelated to this PR

cmd/query/app/http_handler.go

Signed-off-by: cs-308-2023 <[email protected]>

ADI-ROXX · 2025-02-03T05:14:48Z

Hey @ADI-ROXX , I was working on this PR: Migrate DetailsCard from class based to function based component, but there's a problem that before migrating, the /quality-metrics endpoint must be present in order to show the correct results. I see that you're working on this issue, may we collaborate on this, if it's fine with you? Thanks

Hi @yaten2302. I don't think that this PR has much change left. However, if I feel difficulty in something, I will let you know.

Signed-off-by: cs-308-2023 <[email protected]>

ADI-ROXX · 2025-02-08T09:05:57Z

@yurishkuro Do you have any idea for any test in mind for data.go? I don't have any idea for the same.

yurishkuro · 2025-02-09T20:57:31Z

cmd/query/app/qualitymetrics/empty_test.go

+	"github.com/jaegertracing/jaeger/pkg/testutils"
+)
+
+func TestDummy(*testing.T) {


why can't you add a test for GetSampleData?

Signed-off-by: cs-308-2023 <[email protected]>

… dummyRoutes

ADI-ROXX added 2 commits January 23, 2025 23:13

Return 400

1932a2b

Signed-off-by: cs-308-2023 <[email protected]>

Merge remote-tracking branch 'upstream/main'

5288d8c

ADI-ROXX requested a review from a team as a code owner January 25, 2025 16:34

ADI-ROXX requested a review from pavolloffay January 25, 2025 16:34

Create a /quality-metrics endpoint

a9067ad

Signed-off-by: cs-308-2023 <[email protected]>

ADI-ROXX force-pushed the dummyRoutes branch from 1415973 to a9067ad Compare January 25, 2025 16:36

yurishkuro reviewed Jan 25, 2025

View reviewed changes

cmd/query/app/http_handler.go Outdated Show resolved Hide resolved

yurishkuro reviewed Jan 25, 2025

View reviewed changes

ADI-ROXX added 3 commits January 28, 2025 21:28

Dummy data in the correct format

8ca78a8

Signed-off-by: cs-308-2023 <[email protected]>

lint

6b68418

Signed-off-by: cs-308-2023 <[email protected]>

interface{}->any for lint

1861fd4

Signed-off-by: cs-308-2023 <[email protected]>

ADI-ROXX force-pushed the dummyRoutes branch from b71008e to 1861fd4 Compare January 29, 2025 05:40

yurishkuro reviewed Jan 30, 2025

View reviewed changes

yurishkuro mentioned this pull request Feb 2, 2025

add deep dependencies endpoint #6654

Open

4 tasks

Added tests for coverage

ce7929e

Signed-off-by: cs-308-2023 <[email protected]>

yurishkuro added the changelog:bugfix-or-minor-feature label Feb 3, 2025

app/qualitymetrics

3c434b6

Signed-off-by: cs-308-2023 <[email protected]>

ADI-ROXX force-pushed the dummyRoutes branch from e04b283 to 3c434b6 Compare February 8, 2025 08:54

Merge branch 'main' into dummyRoutes

6f55732

yurishkuro reviewed Feb 9, 2025

View reviewed changes

ADI-ROXX added 2 commits February 10, 2025 11:22

basic-test

eb6f2e6

Signed-off-by: cs-308-2023 <[email protected]>

Merge branch 'dummyRoutes' of https://github.com/ADI-ROXX/jaeger into…

8d5df2d

… dummyRoutes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a /quality-metrics endpoint #6608

Create a /quality-metrics endpoint #6608

ADI-ROXX commented Jan 25, 2025 •

edited by yurishkuro

Loading

codecov bot commented Jan 25, 2025 •

edited

Loading

yurishkuro left a comment

yaten2302 commented Jan 30, 2025

yurishkuro Jan 30, 2025

ADI-ROXX commented Feb 3, 2025

ADI-ROXX commented Feb 8, 2025 •

edited

Loading

yurishkuro Feb 9, 2025

Create a /quality-metrics endpoint #6608

Are you sure you want to change the base?

Create a /quality-metrics endpoint #6608

Conversation

ADI-ROXX commented Jan 25, 2025 • edited by yurishkuro Loading

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

codecov bot commented Jan 25, 2025 • edited Loading

Codecov Report

yurishkuro left a comment

Choose a reason for hiding this comment

yaten2302 commented Jan 30, 2025

yurishkuro Jan 30, 2025

Choose a reason for hiding this comment

ADI-ROXX commented Feb 3, 2025

ADI-ROXX commented Feb 8, 2025 • edited Loading

yurishkuro Feb 9, 2025

Choose a reason for hiding this comment

ADI-ROXX commented Jan 25, 2025 •

edited by yurishkuro

Loading

codecov bot commented Jan 25, 2025 •

edited

Loading

ADI-ROXX commented Feb 8, 2025 •

edited

Loading