Fix improper query time when query and forecast timedelta is larger than one day #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly compute seconds for timedeltas > 1 day
|
Thank you for this fix! Do you happen to have any experience managing Python packages as I haven't worked on this for a while and it seems that the way to release them has changed? |
|
I think I've released it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
timedelta.secondsproperty is unreliable when timedeltas are larger than 24hrs (see here)PR replaces this with
timedelta.total_seconds()to get the true value.This may fix #8 .
Thanks for building this great utility!