TESTING #23
Closed
TESTING #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primary Changes
---------------
1. Updated the workflow to include a skip
when the PR author is dependabot
2. Updated the pr-commit parity script to
include Levenshtein Distance string metric
instead of importing a package to reduce
workflow runtime
Changes required to incorporate 1)
3. Updated workflows/pr-commit-parity.yaml with
a conditional statement
Changes required to incorporate 2)
4. Updated the script with the functions,
levensheteinDistance and stringSimilarity
to have the required functionality
5. Updated the package.json with removal of the
package dependency of string-similarity-js
6. Updated the workflow and removed steps to
parse the project, thus reducing workflow
runtime
Fixes hyperledger-cacti#3469
Signed-off-by: jagpreetsinghsasan <[email protected]>
jagpreetsinghsasan
force-pushed
the
feat-3469
branch
from
32ba5e3 to
b6da739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.