Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support objects as jsonb #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

derekwsgray
Copy link

A gap in the Joi schema support was Joi.object(). For default, it converts to string, in the same fashion as for array(). For postgres, it saves the object as JSONB, which is the generally recommended field type in the postgreSQL documentation.

@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #32 into master will decrease coverage by 2.14%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   93.79%   91.64%   -2.15%     
==========================================
  Files           4        4              
  Lines         419      431      +12     
==========================================
+ Hits          393      395       +2     
- Misses         26       36      +10
Impacted Files Coverage Δ
lib/modelGenerators/postgres.js 70.58% <14.28%> (-14.6%) ⬇️
lib/modelGenerators/default.js 76.78% <20%> (-5.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e5c08...4999161. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants