Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapting to the Windows MSVC compilation environment #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adapting to the Windows MSVC compilation environment #25

wants to merge 1 commit into from

Conversation

h20282
Copy link

@h20282 h20282 commented Oct 9, 2023

No description provided.

jakar
jakar reviewed Oct 9, 2023
View reviewed changes
Copy link
Owner

@jakar jakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I assume that you tested this out. Let me know if you can document what those flags are. Then I can merge.

src/CMakeLists.txt Outdated Show resolved Hide resolved
h20282
h20282 commented Oct 11, 2023
View reviewed changes
src/CMakeLists.txt Outdated Show resolved Hide resolved
@h20282
Copy link
Author

h20282 commented Oct 16, 2023

The changes have been completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakar jakar jakar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h20282 @jakar