Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1883: Enhance UIViewRoot#resetValues() to pass VisitHints #1944

Conversation

BalusC
Copy link
Member

@BalusC BalusC commented Aug 4, 2024

#1883

Associated PR in Mojarra: eclipse-ee4j/mojarra#5474

Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment; may as well remove the unnecessary empty line between comment and method

@arjantijms arjantijms added this to the 5.0 milestone Aug 7, 2024
@arjantijms arjantijms merged commit 39d19af into 5.0 Aug 7, 2024
1 check passed
@arjantijms arjantijms deleted the issue_1883_Enhance_UIViewRoot#resetValues()_to_pass_VisitHints branch August 7, 2024 19:16
Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this change is captured in a change log as it changes the behavior ever so slightly (I know it is desired, but lets make sure we document it).

@BalusC
Copy link
Member Author

BalusC commented Aug 26, 2024

It's already linked to https://github.com/jakartaee/faces/milestone/22 so changelog is automatic. Or are you referring to the spec document as in https://jakarta.ee/specifications/faces/4.1/jakarta-faces-4.1#change-log ? That will be done once 5.0 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants