Mojarra issue 5398 move vdldoc and renderkitdoc to faces project #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generate these is already here; any com.sun.faces.* specific entries are basically emptied -- which is harmless as these files are not actually used by Mojarra impl); outcomment the jsdoc config until it's figured out eclipse-ee4j/mojarra#5398 To run them: `mvn clean package -Pdocs`
make sure the mvn clean package -Pdocs runs without errors eclipse-ee4j/mojarra#5398
mnriem
approved these changes
Sep 18, 2024
BalusC
deleted the
mojarra_issue_5398_move_vdldoc_and_renderkitdoc_to_faces_project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-ee4j/mojarra#5398
Basically ensures following finally works fine:
Corresponding PR in Mojarra: eclipse-ee4j/mojarra#5505
NOTE: I had to outcomment jsdoc config because mvn clean package -P docs also executes it and then errors out. The jsdoc config as well as the faces-uncompressed.js file has hard coded mojarra dependencies which can only be fixed by migrating to TypeScript (so we can put interface ts file in Faces project and implementation ts file in Mojarra project). Related: #1598