introduce null-save JsonObjectBuilder.add and JsonGenerator.write met… #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasj
reviewed
Oct 13, 2021
| * Configuration property to ignore null values. All providers | ||
| * must support this property. The value of the property is boolean. | ||
| */ | ||
| public static final String IGNORE_ADDING_IF_NULL = "jakarta.json.JsonBuilderFactory.ignoreAddingIfNull"; |
There was a problem hiding this comment.
what about just IGNORE_NULL? (...and same comment wrt constant in an interface applies)
There was a problem hiding this comment.
what about just
IGNORE_NULL? (...and same comment wrt constant in an interface applies)
Sounds better, I will change that.
But first I am afraid that we need to discuss what to do with this other issue #97 that is very similar to this one.
In that issue it is also possible to serialize to null, and this issue I am not covering that.
Basically we need to choose one issue, and close the other.
jbescos
force-pushed
the
issue213
branch
2 times, most recently
from
b588102 to
5f1f592
Compare
…hods jakartaee#213 Signed-off-by: Jorge Bescos Gascon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#213
This other is also related: #97 but we are not serializing null