-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subsume PR 838 and rebase with HEAD of main #855
Subsume PR 838 and rebase with HEAD of main #855
Conversation
Signed-off-by: Kevin Sutter <[email protected]> Initial draft outline of the core profile specification Signed-off-by: Scott M Stark <[email protected]> Fix typo in CDI lite reference Signed-off-by: Scott M Stark <[email protected]> Initial draft outline of the core profile specification (jakartaee#356) * Initial draft outline of the core profile specification Signed-off-by: Scott M Stark <[email protected]> * Fix typo in CDI lite reference Signed-off-by: Scott M Stark <[email protected]> Prepare next development version (jakartaee#366) Signed-off-by: Ivar Grimstad <[email protected]> removal of managed beans spec content and build process Signed-off-by: Kevin Sutter <[email protected]> PNG to SVG images format conversion. Signed-off-by: Dmitri Cherkas <[email protected]> 1) Figure 5 converted from PNG to SVG, 2) margin of 5 mm is added to Figure 4, 3) Elements are aligned. Signed-off-by: Dmitri Cherkas <[email protected]> 1) Figure 6 converted from PNG to SVG, 2) error corrected in Figure 5. Signed-off-by: Dmitri Cherkas <[email protected]> Figure 7 in SVG format. Signed-off-by: Dmitri Cherkas <[email protected]> Figure 8 in SVG format. Signed-off-by: Dmitri Cherkas <[email protected]> References in the spec from png to svg are updated as requested. Signed-off-by: Dmitri Cherkas <[email protected]> JavaEEapplication_schema.svg conversion Signed-off-by: Dmitri Cherkas <[email protected]> JavaEEapplication_schema.svg errata corrige and other 3 images converted. Signed-off-by: Dmitri Cherkas <[email protected]> JavaEEapplication_schema.svg errata corrige and other 3 images converted. Signed-off-by: Dmitri Cherkas <[email protected]> JavaEEapplication-client_schema.svg errata corrige. Signed-off-by: Dmitri Cherkas <[email protected]> The next images convertion done. Signed-off-by: Dmitri Cherkas <[email protected]> Last images (Platform_Spec-24.svg, Platform_Spec-23.svg, Platform_Spec-21.svg, JavaEEapplication_DTD.svg) converted. Signed-off-by: Dmitri Cherkas <[email protected]> 1) Errata corrige for images 22, 23, 24; 2) all of the doc references updated to point at the svg files instead of the png files. Signed-off-by: Dmitri Cherkas <[email protected]> Begin work on the EE 10.0 specs Update asciidoc related dependencies, clean up warnings and add coreprofile spec generation Set version to 10.0 Signed-off-by: Scott M Stark <[email protected]> Remove applet requirements, jakartaee#298 Change Java SE 8 references to Java SE 11, jakartaee#331 Signed-off-by: Scott M Stark <[email protected]> Address comments from @kazumura Signed-off-by: Scott M Stark <[email protected]> Remove applet requirements, jakartaee#298, update Java SE jakartaee#331 (jakartaee#417) * Remove applet requirements, jakartaee#298 Change Java SE 8 references to Java SE 11, jakartaee#331 Signed-off-by: Scott M Stark <[email protected]> * Address comments from @kazumura Signed-off-by: Scott M Stark <[email protected]> Remove the Applet container from the diagram, jakartaee#298 Signed-off-by: starksm64 <[email protected]> Remove applet container from interoperability diagram Signed-off-by: starksm64 <[email protected]> Remove the managed bean spec generation that was readded in a PR merge. Signed-off-by: starksm64 <[email protected]> Fix the out of date img references that had been converted to svg, jakartaee#435 Signed-off-by: starksm64 <[email protected]> Various errata corriges. Signed-off-by: Dmitri Cherkas <[email protected]> Broken line at the start of 8.3. Class Loading Requirements paragraph. Signed-off-by: Dmitri Cherkas <[email protected]> Broken line at the end of 8.3.3. paragraph Signed-off-by: Dmitri Cherkas <[email protected]> Two errata corrige: 'Jakarta instead of Jaav' and '_multitier applications_' istead of 'multitier __ applications' Signed-off-by: Dmitri Cherkas <[email protected]> Update documentation regarding Java SE base level Start a dependency graph section in the specs Signed-off-by: starksm64 <[email protected]> Correct authentication label Signed-off-by: starksm64 <[email protected]> Add ejb, jta child dependencies Signed-off-by: starksm64 <[email protected]> Label cdi -> {jta, ejb} dependency with javadoc Signed-off-by: starksm64 <[email protected]> Update web profile dependencies to latest versions Signed-off-by: Scott M Stark <[email protected]> First pass at removing core profile requirements, jakartaee#413 Signed-off-by: starksm64 <[email protected]> Add clarification from ksutter. Signed-off-by: starksm64 <[email protected]> Move the JNDI/JTA requirements from Platform profiles section to Web profile Signed-off-by: starksm64 <[email protected]> Address comment from Edwin Signed-off-by: Scott M Stark <[email protected]> Further simplifications Signed-off-by: Scott M Stark <[email protected]> Update specification versions and related documents Signed-off-by: Scott M Stark <[email protected]> Add Jakarta Concurrency 3.0 Signed-off-by: Scott M Stark <[email protected]> Add Jakarta Concurrency Specification 3.0 to related docs Signed-off-by: Scott M Stark <[email protected]> Statement for jakartaee#460, jakartaee#406 Signed-off-by: Scott M Stark <[email protected]> Make the last paragraph a decision statement Signed-off-by: Scott M Stark <[email protected]> Add a future statement regarding JPMS, make clear there are no requirements currently jakartaee#425 Signed-off-by: Scott M Stark <[email protected]> Refine module-info.class description to clarify they are not standard Clarify vendor module-info.class contents can be different and may conflict with those in the spec project API jars. Add a statement about restrictions of using the jakarta package namespace, jakartaee#457 Signed-off-by: Scott M Stark <[email protected]> Just talk about the jakarta package name restrictions. Signed-off-by: Scott M Stark <[email protected]> Minor updates to core profile Signed-off-by: Scott M Stark <[email protected]> Link to working group about page Signed-off-by: Scott M Stark <[email protected]> Address some comments about core profile spec doc Signed-off-by: Scott M Stark <[email protected]> Fix the CDI spec link as there is no separate CDI Lite spec. Signed-off-by: Scott M Stark <[email protected]> Update the component spec versions Signed-off-by: Scott M Stark <[email protected]> Breakout the copyright section to a new document, jakartaee#499 Signed-off-by: Scott M Stark <[email protected]> Address review comments Signed-off-by: Scott M Stark <[email protected]> Order included specs by name drop the managed bean spec Signed-off-by: Scott M Stark <[email protected]> Minor updates to web profile and platform spec Signed-off-by: Scott M Stark <[email protected]> The requirements were really optional behaviors from other specs, so reorg those and add that CDI Java SE is not a requirement. Signed-off-by: Scott M Stark <[email protected]> Correct sorted ordering of required components Signed-off-by: Scott M Stark <[email protected]> Better ordering Signed-off-by: Scott M Stark <[email protected]> Address comments from scottmarlow Signed-off-by: Scott M Stark <[email protected]> Note managed beans are deprecated for removal, jakartaee#502 Signed-off-by: Scott M Stark <[email protected]> Follow through on removal of entity beans and embeddable EJB container Signed-off-by: Scott M Stark <[email protected]> Updated removed list to the EE 10 candidates Signed-off-by: Scott M Stark <[email protected]> Add Connectors 2.1 to to the list Update platform-spec.adoc (jakartaee#506) We added this commemoration for Jakarta EE 9. I guess it is appropriate to take it out from Jakarta EE 10 Update ApplicationProgrammingInterface.adoc Remove version numbers, provide reference to Application Programming Interface chapter for specific versions. Fixed Security Spec. name. Noted Web Services Metadata is moved to XML Web Services. Remove SOAP with Attachments version from table Order specifications alphabetically to match Profiles ordering Rename Server Pages Debugging to Debugging Support for Other Languages Signed-off-by: Scott M Stark <[email protected]> Address TBDs in platform spec Signed-off-by: Scott M Stark <[email protected]> Include the removed tech in the changes Signed-off-by: Scott M Stark <[email protected]> Address jakartaee#567, fix old specification version references. Signed-off-by: Scott M Stark <[email protected]> update profile names in CCR request template (jakartaee#649) Add a tck challenge template Simplifying spec generation switch to Asciidcotor pdf generation (remove docbook). Twick licence blocks to have a nice pdf version CDI-538 Section 3.8 on CDI 1.2 spec javax.security.Principal (now in 17.8) CDI-416 Typo on @PersistencContext Fix minor grammar mistakes Introduce new ref in EE for TCK Fix interceptors_ee.asciidoc file name. Cleaning source asciidoc files to have one sentence per line Migrating to Asciidoctor 1.5+ notation CDI-553 move notion of "security context" to EE part. CDI-545 observers can be only local bussines method. CDI-569 Add @ObservesAsync where the spec mention @observes Correct sources to match one sentence per line CDI-571 producer and disposer methods can be only local bussines method of EJB. (jakartaee#284) Correcting typos on Asciidoctor links CDI-555 remove the outdated wording linked to previous Java SE boot api CDI-500 Clarify @Intercepted bean metadata injection for EE components (jakartaee#318) additional fix - missing chapter id. (jakartaee#325) CDI-625 Make it clear when exactly are context init/destroy events fired (jakartaee#303) - add @BeforeDestroyed Few language updates (jakartaee#329) Nice to see text reviewer ;). Thx @tremes. CDI-667 introduce new chapter for trimmed bean archive in Java EE. (jakartaee#368) Cleaning Javadoc and typos remove unused import minor syntax update to java 8 CDI-495 What happens if an illegal bean type is found in the set of bean types (jakartaee#363) CDI-689 Typo or unclear message in 24.1.2 (jakartaee#382) CDI-690 Request Context Clarification (jakartaee#385) Clarify in core when request context is active, and change verbiage a bit to align to common term of context. change from javax.* to jakarta.* (jakartaee#414) Signed-off-by: Scott Marlow <[email protected]> Jakartify (jakartaee#444) * Jakartify definition Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify decorators Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify events Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify implementation Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify inheritance Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify inject Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify interceptors Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify intro Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify lifecycle Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify packaging Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify scopes Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify spi Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify core packaging Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify core spi Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify inject Signed-off-by: Ivar Grimstad <[email protected]> * Jakartify resolution Signed-off-by: Ivar Grimstad <[email protected]> * Fix javax.* references to jakarta.* Signed-off-by: Ivar Grimstad <[email protected]> * Fix javax.annotation.ManagedBean reference in javadoc to jakarta.annotation.ManagedBean Signed-off-by: Ivar Grimstad <[email protected]> Fix the javax.servlet package usage Signed-off-by: Scott M Stark <[email protected]> Removal of deprecated APIs: BeanManager.fireEvent() Removal of deprecated APIs: @New comprehensive review and various Lite/Full split changes Rename files and chapter refereces to align with rest of the specification Bump CDI version to 4.1 and place EL integration API in a new supplemental artifact (jakartaee#644) * Fix remnants of BeanManager.fireEvent() removal * Centralize common Maven properties in the parent POM * Fix EL import version in bundle metadata * Bump CDI version to 4.1 * Place the EL integration API to ELAwareBeanManager in a new supplemental API artifact The existing EL integration API in `BeanManager` is deprecated for removal. Remove references to the removed jakarta.annotation.ManagedBean jakartaee#750 Signed-off-by: Scott M Stark <[email protected]> Move the CDI EE integration spec requirements to a new cdi-ee-spec directory Signed-off-by: Scott M Stark <[email protected]> The initial migration of the CDI component specification EE integration requirements, jakartaee#837 Signed-off-by: Scott M Stark <[email protected]> Add an approach to correct the missing cross-references. Signed-off-by: Scott M Stark <[email protected]> Add an approach to correct the missing cross-references. Signed-off-by: Scott M Stark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the content from the CDI integration section is here
Yes for WebProfile, not for CoreProfile.
…On Tue, Mar 5, 2024 at 11:42 AM Jared Anderson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In specification/src/main/asciidoc/platform/Platform.adoc
<#855 (comment)>:
> @@ -23,6 +23,8 @@ include::ServiceProviderInterface.adoc[]
include::CompatibilityMigration.adoc[]
+include::IntegrationRequirements.adoc[]
Does there need to be a similar include for WebProfile.adoc and
CoreProfile.adoc?
—
Reply to this email directly, view it on GitHub
<#855 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRDMWE3J4MXTZXIK2DO2TYWX7WTAVCNFSM6AAAAABEGEHIHWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJXG4YDQNJUHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Your branch is up to date with 'origin/edburns-msft-redhat-cdi-integration-838'. Changes to be committed: (use "git restore --staged <file>..." to unstage) new file: specification/src/main/asciidoc/shared-includes/IntegrationRequirements.adoc Changes not staged for commit: (use "git add/rm <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: specification/pom.xml deleted: specification/src/main/asciidoc/platform/IntegrationRequirements.adoc modified: specification/src/main/asciidoc/platform/Platform.adoc modified: specification/src/main/asciidoc/webprofile/WebProfile.adoc Signed-off-by: Ed Burns <[email protected]>
specification/src/main/asciidoc/platform/cdi-ee-spec/implementation_ee.adoc
Outdated
Show resolved
Hide resolved
specification/src/main/asciidoc/platform/cdi-ee-spec/implementation_ee.adoc
Show resolved
Hide resolved
specification/src/main/asciidoc/platform/cdi-ee-spec/implementation_ee.adoc
Show resolved
Hide resolved
…-spec Built-in beans from CDI integration spec. modified: spec/src/main/asciidoc/concepts.adoc Addresses jakartaee/platform#855 (review) Signed-off-by: Ed Burns <[email protected]>
…#855 (review) from @arjantijms modified: specification/src/main/asciidoc/platform/cdi-ee-spec/implementation_ee.adoc Move this text to jakartaee/security#323 . Signed-off-by: Ed Burns <[email protected]>
…lated buitlt-in bean. modified: specification/src/main/asciidoc/platform/cdi-ee-spec/implementation_ee.adoc Signed-off-by: Ed Burns <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this PR was subsumed from #838 , and that PR had no commits authored by me, I am effectively serving as a reviewer for that PR in this one. Therefore, this counts as my review.
Steps taken to arrive at this PR.
[email protected]:jakartaee/jakartaee-platform.git
is up to date with the upstream.git remote add jakartaredhat [email protected]:jakartaredhat/jakartaee-platform.git
git fetch --all
cdi-ee
branch fromjakartaredhat
remote. My existing checkout is the branch for this PR.cdi-ee
branch I rangit rebase -i HEAD~37
.pick
and set all the remaining lines tosquash
.cdi-ee
branch) to the branch for this PR using this script.Here is the PR message from #838 for reference.
This is a work in progress to incorporate the CDI specification EE integration requirements to the platform.
This PR appears to include several commits in order to preserve the history of the related content from the CDI specification repository.
One big issue to resolve with this is how to handle the cross references to the CDI specification that no longer resolve. (FIXED)
fixes #837
AB#335