closes #1266, implement Form equals method and add unit tests #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansupol
requested changes
Oct 3, 2024
mkarg
reviewed
Oct 3, 2024
- fix copyright in unit test - add hashCode method for Form class - swap asMap to parameters in Form equality check - fix Boolean warning in Form unit test
mkarg
requested changes
Oct 3, 2024
mkarg
approved these changes
Oct 3, 2024
jamezp
reviewed
Oct 3, 2024
jansupol
approved these changes
Oct 9, 2024
|
Assuming there are no further changes required, would someone mind merging this PR? |
According to our general Committer Conventions the default voting period is two full weeks. Hence this PR cannot get merged before October 17. I will do the merge once the period is over and there was no -1 vote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.