Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta RESTful Web Services 4.0.0 #724

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

jim-krueger
Copy link
Contributor

@jim-krueger jim-krueger commented Apr 3, 2024

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

  • A directory in the form wombat/x.y where x.y is the release major.minor version, and the directory contains the following.
  • Specification PDF in the form of jakarta-wombat-spec-x.y.pdf
  • Specification HTML in the form of jakarta-wombat-spec-x.y.html
  • A specification page named _index.md following the template at:
    https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
  • For a Progress Review, that sufficient progress has been made on a Compatible Implementation and TCK, to ensure that the spec is implementable and testable.
  • For a Release Review, a summary that a Compatible Implementation is complete, passes the TCK, and that the TCK includes sufficient coverage of the specification. The TCK users guide MUST include the instructions to run the compatible implementations used to validate the release.
    Instructions MAY be by reference.
    • Updated release record
    • Send an email to the EMO (with cc to the PMC) that contains a link to this PR and a request to the PMC for approval. The EMO will append a checklist to the PR to track the review
  • The URL of the OSSRH staging repository for the api, javadoc:
    restful-ws api/javadoc
  • The URL of the staging directory on downloads.eclipse.org for the proposed EFTL TCK binary:
    restful-ws tck eftl
  • The URL of the compatibility certification request issue:
    RESTEasy Java 17 - CCR
    RESTEasy Java 21 - CCR
    Jersey Java 17 - CCR
    Jersey Java 21 - CCR
  • Specification JavaDoc in the wombat/x.y/apidocs directory.
    If desired, an optional second PR can be created to contain just the JavaDoc in the apidocs directory.

Note: If any item does not apply, check it and mark N/A below it.

@jim-krueger jim-krueger marked this pull request as draft April 3, 2024 13:20
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit 1e74fb1
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/6613f60ed4ce0e0008515e7e
😎 Deploy Preview https://deploy-preview-724--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ivargrimstad ivargrimstad added the release review Use this label on PRs that are filed for release review label Apr 3, 2024
@ivargrimstad ivargrimstad self-assigned this Apr 3, 2024
@scottmarlow
Copy link
Contributor

https://deploy-preview-724--jakartaee-specifications.netlify.app/specifications/restful-ws/4.0/ shows:

Compatible Implementations

    [Eclipse Jersey 4.0](https://projects.eclipse.org/projects/ee4j.jersey)

Shouldn't the Compatible Implementations be updated to list RESTEasy on Java 17 + RESTEasy on Java 21?

CC @jamezp

@jamezp
Copy link

jamezp commented Apr 3, 2024

@scottmarlow We could add RESTEasy, but AIUI Jersey should be happening very soon.

@jim-krueger jim-krueger force-pushed the release-restfulws-4.0 branch 2 times, most recently from 6e5d760 to b02343d Compare April 3, 2024 19:43
@ivargrimstad
Copy link
Member

ivargrimstad commented Apr 4, 2024

Mentor Spec Review Checklist

  1. Spec PR
  1. _index.md
  1. javadocs
  • Footer contains Eclipse copyright and link to license
  • ESFL license is included, usually as doc-files/speclicense.html
  • no META-INF directory in PR
  • javadocs-jar artifact matches apidocs (optional for this release)
  1. Spec PDF
  • Correct spec title
  • Version number of the form x.y, not x.y.z
  • Correct Eclipse copyright line
  • No DRAFT or SNAPSHOT
  • Correct Logo
  1. Spec HTML
  • Same as PDF
  1. TCK zip file
  • README file (optional for this release)
  • EFTL license file, preferably named LICENSE.md
  • User's Guide (or equivalent documentation)
  • How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)
  1. TCK User's Guide (or equivalent documentation)
  • Software requirements listed
  • Installation and configuration described
  • How to run tests
  • Where to file challenges
  1. Compatibility certification request
  • Request follows template
  • SHA-256 fingerprint matches staged TCK zip file
  • Request issue has certification label.
  1. TCK results summary
  • Page is hosted by Compatible Implementation project
  • Includes all information from certification request
  • Summary includes number of tests passed, failed, errors
  • SHA-256 fingerprint matches staged TCK zip file on cert request
  1. If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to [email protected].
    (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
    release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)

    • The specification project team requests approval for the release from the PMC by sending an email to [email protected].
  2. Update Jakarta EE API jar

@jim-krueger jim-krueger force-pushed the release-restfulws-4.0 branch 3 times, most recently from dea0910 to 2aa7a70 Compare April 4, 2024 19:07
Copy link

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think we could add the download for Jersey too, but that's a minor update so I'm approving.

@jim-krueger jim-krueger marked this pull request as ready for review April 10, 2024 19:40
@ivargrimstad ivargrimstad added the ballot Delivered to the Specification Committee for ballot label Apr 10, 2024
@mtdelgadoa
Copy link

mtdelgadoa commented Apr 11, 2024

EMO REVIEW CHECKLIST

EDP Review status: COMPLETED

EMO review checklist

PMI record: URL

EF Specification Process

  • Spec Committee Ballot completed

Intellectual Property Management

  • All project code has copyright and license headers correctly applied. ** EMO will scan the code at their discretion **
  • All distributed third-party content has been vetted by the IP Due Diligence process (i.e., IP Log has been approved)

Open Source Rules of Engagement

General:

  • Project is operating within the mission and scope defined in its top-level project’s charter
  • Project is operating within the bounds of its own scope
  • Project is operating in an open and transparent manner
  • Overall the project is operating according to the Eclipse Development Process.

Things to check:

  • Communication channels advertised
  • Advertised communication channels used
  • Committers are responding to questions
  • Committers are responding to issues
  • Committers are responding to pull/merge/review requests

Branding and Trademarks
The following applies when the project has a custom website.
To the best of our knowledge:

  • Project content correctly uses Eclipse Foundation trademarks
  • Project content (code and documentation) does not violate trademarks owned by other organizations

Things to check:

  • Project website uses the project's formal name in first and all prominent references
  • Project website includes a trademark attribution statement
  • Project website footers contain all necessary elements

Legal Documentation
Required files:

  • License files in all repository roots
  • README
  • CONTRIBUTING (or equivalent)

Recommended files:

See examples for Security file and Code of Conduct.

Required elements:

  • ECA is referenced/described

Recommended elements:

Metadata (PMI)

  • The formal name, e.g. "Eclipse Foo™", is used in the project title
  • The formal name including appropriate marks (e.g, "™") is used in the first mention in the text of the project description, and scope
  • The project description starts with a single paragraph that can serve as an executive summary
  • Source code repository references are up-to-date
  • Download links and information are up-to-date (see EF handbook for more information on how-to do this)
  • Communication channels listed in the PMI (i.e. public mailing list, forums, etc.)

@ivargrimstad ivargrimstad added approved The ballot was approved by the Specification Committee and removed ballot Delivered to the Specification Committee for ballot labels Apr 25, 2024
@ivargrimstad
Copy link
Member

ivargrimstad commented Apr 25, 2024

  • On ballot completion, the specification committee mentor:

@ivargrimstad ivargrimstad merged commit 211a08a into jakartaee:master Apr 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee release review Use this label on PRs that are filed for release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants