Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable removeViewbox plugin #402

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

XhmikosR
Copy link
Collaborator

While svgo still has this enabled by default, it can cause issues

See svg/svgo#1461 for more details

While svgo still has this enabled by default, it can cause issues
@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for svgomg ready!

Name Link
🔨 Latest commit 5e876e8
🔍 Latest deploy log https://app.netlify.com/sites/svgomg/deploys/65e328797d3f2300074efabb
😎 Deploy Preview https://deploy-preview-402--svgomg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Darkproduct
Copy link

Oh, and don't forget to read this for a lot more detail: svg/svgo#1128

@Lucienest
Copy link

While svgo still has this enabled by default, it can cause issues

See svg/svgo#1461 for more details

People were complaining about this for many years but the sole owner of this project won't listen.

@SethFalco
Copy link

SethFalco commented Nov 24, 2023

It will be some time before we make the change in SVGO (v4 release), so I'd recommend merging this into SVGOMG already.

It may also be worth adding either a warning, or including a link to the documentation for each plugin, so users are more informed on potential consequences of them.

https://svgo.dev/docs/plugins/remove-viewbox/

@jakearchibald
Copy link
Owner

My bigger plan here is to extend each plugin with its individual options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants