Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): add #[derive(Deserialize)] to model types #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michaelhthomas
Copy link

It is recommended for data model types to implement serde's Deserialize trait. The majority of types in this library already implement Deserialize, but the search module is an exception, making it impossible to, for example, deserialize a search filter from JSON. This PR adds the #[derive(Deserialize)] macro to types which were previously missing it, making it possible to deserialize search filters, sorts, etc. using serde.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant