[WIP] Homie v3.0.0 #47

bodiroga · 2018-10-07T21:15:19Z

This PR is a WIP to update the library to the latest Homie version: 3.0.0. https://github.com/homieiot/convention

Even if it is WIP, I have updated all the example files to the new API and in my preliminary test everything works fine 👍 But I would like to know for opinion about the new class names and functions. Don't hesitate to suggest or criticize whatever you want 😝

Best regards,

Aitor

- Rename Homie class to Device. - Update Node method to addNode. - Update property subscription mechanism. callback(property, value).

jalmeroth · 2018-10-08T19:13:39Z

Hi Aitor,

wow impressive work, once again! Have you seen my efforts in dev from 8 months ago? It might makes more sense to merge your changes here.

Let me know what you think.

Best regards,
Jan

bodiroga · 2018-10-19T21:44:53Z

Hi Jan (@jalmeroth)!

Sorry, but I'm not sure if I have understood what you mean. Do you want me to make my changes against your dev branch? I don't know if that's going to be easy 😞 Anyway, we should talk about how to handle this situation: what Homie version should we support in the library? Homie v2? Homie v3? Both at the same time? What's the best way to deal it? Two repositories and two libraries (homie-python and homie3-python)? Everything in the same repository? What about the "pip" installation process? How can that be managed?

I think that I will wait until we decide something about this before changing anything in the PR 😉

Best regards!

Aitor

bodiroga · 2018-12-13T09:06:37Z

Hi @jalmeroth!

I have made a new commit to update the library to Homie 3.0.1 (they have introduced a new "$retained" attribute to the properties to make them stateless) and have added two new examples.

Let me know how do you want to address the different versions of the library (Homie 2 and Homie 3) and looking forward to seeing the library marked as stable 😉

Best regards

Aitor

esdeboer · 2019-01-05T19:20:28Z

Hi @bodiroga,

Shouldn't the isValidFormat check in helper.py check for none for everything except enum and color, as the format is not required for the other datatypes? (or is it because of my old python 3.4 on my pi that I get a WARNING:homie.property:'None' is not a valid format for float)

Regards,
Eric

stefanroellin · 2019-01-06T16:52:39Z

I have tested the branch and have found the following issues:

in the 3.0 specification "$online" is not used anymore, however there are still updates to this topic. Should probably be replaced with "$state".
during startup there is a warning that the deviceId is invalid, (since it is set to "None" in __init__)
personally I am not interested in the "signal" topic. Hence a possibility to exclude it would be good.

Thanks for your work!

rafdaems · 2019-01-16T10:37:59Z

Thank you very much for this fork.
My openhab installations seems to autodetect mqtt subscribers created by your framework.

One question:
I don't understand the implementation of "settable".
see: https://homieiot.github.io/specification/
under 6.4.1 properties.

pls advise ?

ababilone · 2019-02-11T12:29:06Z

Hi there,

Any news on this subject ? I'm also working on an OpenHAB 2.4 integration and this 3.0 binding is just what It needs. The work done by @bodiroga looks awesome.

Do you plan to merge it someday ?

Thanks for any feedback!

Signed-off-by: Aitor Iturrioz <[email protected]>

bodiroga · 2019-03-21T15:48:41Z

Hi guys!

Shouldn't the isValidFormat check in helper.py check for none for everything except enum and color, as the format is not required for the other datatypes?

Fixed @esdeboer!

in the 3.0 specification "$online" is not used anymore, however there are still updates to this topic. Should probably be replaced with "$state".

Fixed @stefanroellin!

during startup there is a warning that the deviceId is invalid, (since it is set to "None" in init)

Fixed!

personally I am not interested in the "signal" topic. Hence a possibility to exclude it would be good.

Yeah, you are right, but as Homie 4 is going to completely remove the "stats" information, I'm going to keep it for now. It doesn't cause any harm and someone can find it useful 😉

pls advise ?

Hi @rafdaems! Could you please be more specific? I need to know first what is what you don't understand? 👍

Please, test the new changes and report if you find any error! Thanks for you help! 👍

Best regards,

Aitor

esdeboer · 2019-03-22T10:52:09Z

Thanks for the fixes Aitor, looks good.
I don't get the deviceId warning anymore and I can add properties with a datatype without format.

Kixunil · 2019-03-31T20:08:30Z

Hi, thanks a lot for this code! I used it for solight-homie and it works with OpenHAB. It's very nice how easily I could create a plugin for OpenHAB using this code.

stedon81 · 2019-04-06T20:33:22Z

Hi,
I experienced some hang up issues with this homie implementation in this branch. Is it possible, that this library is not thread-safe? From my code, it looks like different threads would block each other if they try to do update or read operations at the same time.
Regards,
stedon81

stedon81 · 2019-04-06T20:42:32Z

OK, I found the answer - it's not homie, but the underlying paho mqtt library which is not thread safe:
eclipse-paho/paho.mqtt.java#453 (comment)
Nevermind, sorry to have bothered :-)

mjcumming · 2019-04-29T14:56:35Z

I have put together a python library for Homie 3 that I would like some feedback on. You can get it here

https://pypi.org/project/Homie3/

Mike

yozik04 · 2019-05-07T18:44:44Z

I think this pull request needs to land to a separate repo and produce a separate pip package.

bodiroga added 26 commits October 6, 2018 12:32

Move 'property' to its own file

ae5b02b

Move 'examples' to their own folder

c4c304b

Add a method to check if datatype is valid

85ad939

Add more attributes to HomieNodeProperty

beb58a4

Update HomieNodePropertyRange class

0113f9a

Rename 'announce' methods to 'addProperty'

1cee0b2

Return 'property' object in the addProperty method

e1b59ba

Rename 'setProperty' to 'getProperty'

e2b2719

Publish property attributes when nodes are published

30a204e

Rename 'sendProperties' to 'publishProperties'

5f00be2

Properly implement fields getters and setters

bce5fee

Add validation functions for format and units

c12631d

Fix error in isValidId function

f0df5cb

Improve format validation

4eedb38

Check if datatype, format and unit are valid

b9a285c

Fix property creation in node class

ff65f56

Check if nodeId is valid

4efbcea

Raise ValueError exception if property id is invalid

8fe0097

Update the subscribe mechanism for properties

c7685b9

Rename 'send' method to 'update'

9511fcf

Rework main file

2d4cb76

- Rename Homie class to Device. - Update Node method to addNode. - Update property subscription mechanism. callback(property, value).

Publish 'stats' information

27581ad

Implement 'state' attributes

0f88fbf

Implement 'name' attribute for nodes

840fde0

Update homie version to 3.0.0

2dc3968

Update all example files

83e556b

Update to Homie 3.0.1 and add more examples

fcb9561

bodiroga mentioned this pull request Dec 20, 2018

Where do we want to go from here? #38

Open

Fix $stats mismatch with specification

b4c4b41

bodiroga added 3 commits March 21, 2019 16:08

Remove '' topic usage

da3362b

Signed-off-by: Aitor Iturrioz <[email protected]>

Remove "self.deviceID = None" statement

f63afa1

Allow no format for certain datatypes

5a8388d

yozik04 mentioned this pull request May 3, 2019

Development: adding homie ParadoxAlarmInterface/pai#75

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Homie v3.0.0 #47

[WIP] Homie v3.0.0 #47

bodiroga commented Oct 7, 2018

jalmeroth commented Oct 8, 2018

bodiroga commented Oct 19, 2018 •

edited

Loading

bodiroga commented Dec 13, 2018

esdeboer commented Jan 5, 2019 •

edited

Loading

stefanroellin commented Jan 6, 2019

rafdaems commented Jan 16, 2019

ababilone commented Feb 11, 2019

bodiroga commented Mar 21, 2019

esdeboer commented Mar 22, 2019

Kixunil commented Mar 31, 2019

stedon81 commented Apr 6, 2019

stedon81 commented Apr 6, 2019

mjcumming commented Apr 29, 2019

yozik04 commented May 7, 2019

[WIP] Homie v3.0.0 #47

Are you sure you want to change the base?

[WIP] Homie v3.0.0 #47

Conversation

bodiroga commented Oct 7, 2018

jalmeroth commented Oct 8, 2018

bodiroga commented Oct 19, 2018 • edited Loading

bodiroga commented Dec 13, 2018

esdeboer commented Jan 5, 2019 • edited Loading

stefanroellin commented Jan 6, 2019

rafdaems commented Jan 16, 2019

ababilone commented Feb 11, 2019

bodiroga commented Mar 21, 2019

esdeboer commented Mar 22, 2019

Kixunil commented Mar 31, 2019

stedon81 commented Apr 6, 2019

stedon81 commented Apr 6, 2019

mjcumming commented Apr 29, 2019

yozik04 commented May 7, 2019

bodiroga commented Oct 19, 2018 •

edited

Loading

esdeboer commented Jan 5, 2019 •

edited

Loading