Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved hindi translation for 'ago' #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aruhant
Copy link

@aruhant aruhant commented Jun 27, 2024

What does this PR do?

This PR fixes the Hindi translation for 'ago'
पूर्व is a better hindi translation for 'ago'.
The current word पहले means 'before' and not 'ago'.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance change (non-breaking change such as upgrading a dependency, refactoring, or making a lint fix)
  • Documentation update
  • Breaking change (a fix or feature that would cause existing functionality to change)

Checklist

  • Wrote additional tests, if needed
  • All tests have passed, you can find the scripts from the ./bin folder
  • I have updated the documentation accordingly, if needed.

Additional Information

Reference to Hindi dictionary, that explains why this is a better translation:
https://www.collinsdictionary.com/hi/dictionary/hindi-english/%E0%A4%AA%E0%A5%82%E0%A4%B0%E0%A5%8D%E0%A4%B5

Also, I am a native and profecient Hindi speaker.

पूर्व is a better hindi translation for 'ago'.
The current word पहले means 'before' and not 'ago'
ps: I am a native Hindi speaker.
@aruhant aruhant requested a review from jama5262 as a code owner June 27, 2024 09:15
@jama5262
Copy link
Owner

jama5262 commented Jul 3, 2024

Thanks for your contribution @aruhant

Please update also test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants