Upgrade applyAsync signature #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamauro what do you think? |
|
Thanks for the PR. It'll need some testing in 2.x and 3.x. In my previous testing, using the callback was needed to suppress the invocation failed error in 3.x but I'm not sure if anything has changed there in the latest releases. If you're willing to help with this, I'd appreciate it otherwise I hope to be able to take a closer look soon. Also I think the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking down the issues with #19 I came to
applyAsyncfunction that still had an old callback style response. Migrating it tocatchandthensolved the issue for me.I believe this might have been because the callback was not being called properly.