feat: Update color converter page (HEX / RGB Converter) #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hex Color converter is now Color Converter to convert not just only Hex to RGB but even more.
|
adding HSV to this would potentially increase interest from the luau community |
|
Thanks for creating this PR! I'm on vacation until 9th September, after that I'm going to have a look! |
golergka
reviewed
Oct 1, 2024
|
|
||
| export type ColorValue = RGBValues | HSLValues | CMYKValues | HSVValues | string; | ||
|
|
||
| export const isValidHex = (hex: string) => { |
There was a problem hiding this comment.
I think a couple of unit tests for this function wouldn't hurt
| return !isNaN(value) && value >= 0 && value <= 255; | ||
| }; | ||
|
|
||
| export const convertToRGB = (hex: string): RGBValues => { |
There was a problem hiding this comment.
As well as for other conversion functions
| return { r, g, b }; | ||
| }; | ||
|
|
||
| export const convertToHex = (r: string, g: string, b: string) => { |
There was a problem hiding this comment.
Why three named parameters and not just RGBValues as input?
| }; | ||
|
|
||
| export const toCss = (rgb: RGBValues) => { | ||
| if (!rgb || typeof rgb.r === 'undefined' || typeof rgb.g === 'undefined' || typeof rgb.b === 'undefined') { |
There was a problem hiding this comment.
This shouldn't be possible in the first place
| const valueToFixed = (value: string) => (parseInt(value) / 255).toFixed(2); | ||
|
|
||
| export const toIOS = (rgb: RGBValues, lang: "swift" | "c"): string => { | ||
| if (!rgb || typeof rgb.r === 'undefined' || typeof rgb.g === 'undefined' || typeof rgb.b === 'undefined') { |
There was a problem hiding this comment.
Some point on unnecessary checks here
| @@ -0,0 +1,222 @@ | |||
| export interface RGBValues { | |||
| r: string; | |||
There was a problem hiding this comment.
Why not just use number here in the first place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team,
I've made some significant improvements to the Color Converter tool (HEX / RGB Converter). Instead of just handling HEX to RGB conversions, it now supports conversions between HEX, RGB, HSL, and CMYK formats.
Here's what's new:
I think this update will make the tool much more useful for our team and potentially save us some time when working with various color systems.
I'd appreciate it if you could take a look and let me know your thoughts. If it seems valuable to you too, I'd love to get this merged into the main branch.
Looking forward to your feedback! 🔥