New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Validation logic into a shared builder for re-use across modules #35

Merged

james-d12 merged 3 commits into main from feature/validation

Mar 1, 2025

Owner

james-d12 commented Mar 1, 2025

Consolidate Validation logic into a shared builder for re-use across modules.

I have implemented a ValidationBuilder which allows the building and validating of settings in various formats.
I have introduced a class hierachy (1 level only) to allow some type constraints on the builder. Each module can be enabled / disabled, so having a shared settings hierachy makes some sense.
Added in test coverage for github and gitlab modules for settings check

james-d12 added 2 commits

March 1, 2025 14:34


          Added in validation builder and unit tests before changing modules

f0c3981


          converted all modules to use new validation builder

fad8775

james-d12 linked an issue

that may be closed by this pull request

Encapsulate Validation Logic into shared Class #30

Closed


          Tests for validation builder

c14a5aa

james-d12 merged commit 78cc0b0 into main

1 check passed

james-d12 deleted the feature/validation branch

March 1, 2025 15:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet