choose web socket scheme based on window.location.protocol #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
confirmed that this PR works: |
|
I published an docker image containing all pull requests. |
lumpi2k
added a commit
to lumpi2k/tplink-energy-monitor
that referenced
this pull request
Nov 17, 2022
See jamesbarnett91#57 for details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the application to be accessed via https by testing the protocol being used as
https:and then setting the web socket scheme towssinstead ofws.For example, I have an nginx server in front of my tplink-energy-monitor app. I was receiving Console errors like this:
