Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added experimental support for reading bcf files. #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added experimental support for reading bcf files. #184

wants to merge 1 commit into from

Conversation

danielecook
Copy link

I've added support for bcf files by using bcftools. Supports fetching specific regions and iteration. Includes checking that indices exist, and that bcftools is available.

@sambrightman
Copy link

This seems reasonable if it works. It would be good to:

  • add tests to prove it works
  • fix the merge conflicts with master
  • probably remove which function - seems like a lot of code to add for something simple. there'll be an exception anyway if it's not executable.
  • PEP8-ify things a bit (e.g. spaces after commas, use and not condition instead of and condition == False)
  • maybe use os.path.splitext on the filename further up, to replace multiple endswith comparisons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants