Correct for segfault in variant access - use get_if non-throw

jamescowens · Jan 4, 2024 · a05a4bb · a05a4bb
1 parent 17ca5b1
commit a05a4bb
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/qt/sidestaketablemodel.cpp b/src/qt/sidestaketablemodel.cpp
@@ -334,8 +334,11 @@ Qt::ItemFlags SideStakeTableModel::flags(const QModelIndex &index) const
 
     Qt::ItemFlags retval = Qt::ItemIsSelectable | Qt::ItemIsEnabled;
 
-    if (!rec->IsMandatory()
-        && std::get<GRC::LocalSideStake::Status>(rec->GetStatus()) == GRC::LocalSideStake::LocalSideStakeStatus::ACTIVE
+    GRC::SideStake::Status status = rec->GetStatus();
+    GRC::LocalSideStake::Status* local_status_ptr = std::get_if<GRC::LocalSideStake::Status>(&status);
+
+    if (!rec->IsMandatory() && local_status_ptr
+        && *local_status_ptr == GRC::LocalSideStake::LocalSideStakeStatus::ACTIVE
         && (index.column() == Allocation || index.column() == Description)) {
         retval |= Qt::ItemIsEditable;
     }