Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow to start in search mode (Closes #36) #37

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Horgix
Copy link
Contributor

@Horgix Horgix commented Nov 11, 2020

This is a really naive and bare bones implementation of #36, which allow starting in search mode for emoji choice by configuring it in the template file like so:

Prompts:
    - Type: gitmoji
      Mandatory: true
      Name: gitmoji
      Config:
        StartInSearchMode: true

This is only a draft for now, I'm looking for feedback on the approach. I tried to make it configurable though top-level configuration keys in the file as well as through the CLI flags but for now the templating part is completely split from the rest of the processing so it was kind of a hassle to do it like that. I instead went with the Prompt configuration, and the Config map could open to other usecases imho.

If this feature and this approach was to be approved in theory, I would add relevant examples/docs to the README as well as maybe some comments on how it works / some more checks to ensure nothing goes wrong with such a Config map 🙂

@Horgix Horgix marked this pull request as draft November 11, 2020 14:18
@jamesdobson
Copy link
Owner

I like the way you made it configurable in the template configuration itself. This seems more realistic than expecting someone to pass a CLI flag every time.

I wouldn't mind if you changed the default, when it is unspecified, to search. I think that's an easier experience for users in most cases.

There's another use case I was thinking of where this generic Config map would be useful. That too, would require a boolean value. I'm thinking there may be cases where a value other than boolean is needed. Any thoughts on how to accomplish that? Or, if we want the value to always be boolean, rename it to Flags? I'm open to suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants