🆕 🎓 Iterator Lab --- Create #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshughes89
added
enhancement/new 🆕
twentylemon
approved these changes
Mar 7, 2023
Comment on lines
+73
to
+74
| Improve ``equals`` | ||
| ------------------ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Create a new lab on iterators
Why
Based on the existing labs already prepared, the next lab would be on recursion, however that topic will not be covered in time for the upcoming lab. Having a lab on iterators seemed like the best topic to hit in the meantime such that the recursion lab can be used for the subsequent lab.
Overall, I really like this lab. I think it seems like a lot of work, but in reality it should be relatively straightforward, especially since a lot of it is already explicitly discussed in the topic.
Testing
👍 built local, looks good. Checked all the links.
Additional Notes
Perhaps a lab before the previous lab on the
LinkedSortedBagwould have been better served as a way to hold off on the recursion lab, but it's too late for that. That said, (1) I like this iterators lab, and (b) I am not quite sure what the lab topic could have been between the queue and sorted bag labs as there really wasn't much discussed between the topics (maybe inheritance? though, that's indirectly hit in the bag lab). Perhaps something like comparable (#873) could have worked? Either way, it is what it is for now.