Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename feature llvm18-0 to llvm18-1 #18

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jamesmth
Copy link
Owner

Closes #16

@jamesmth jamesmth force-pushed the fix/llvm-18-feature-naming branch 2 times, most recently from 4e63e95 to 17e49c5 Compare January 10, 2025 09:44
@jamesmth jamesmth self-assigned this Jan 10, 2025
@jamesmth jamesmth force-pushed the fix/llvm-18-feature-naming branch 2 times, most recently from 7585a20 to edd0222 Compare January 10, 2025 10:17
LLVM 18.0 doesn't exist for some reason.

A side-effect is that we can no longer use the convenient macro
`inkwell_internals::llvm_versions` (which only works if the feature is named
"llvm18-0").
@jamesmth jamesmth merged commit 2d4df38 into master Jan 10, 2025
82 checks passed
@jamesmth jamesmth deleted the fix/llvm-18-feature-naming branch January 10, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM Version 18-0 is misleading
1 participant