Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation lints #152

Merged
merged 3 commits into from
May 13, 2024
Merged

Fix documentation lints #152

merged 3 commits into from
May 13, 2024

Conversation

ia0
Copy link
Contributor

@ia0 ia0 commented May 13, 2024

No description provided.

Copy link

netlify bot commented May 13, 2024

Deploy Preview for cute-starship-2d9c9b canceled.

Name Link
🔨 Latest commit 8b64a7d
🔍 Latest deploy log https://app.netlify.com/sites/cute-starship-2d9c9b/deploys/66423c584fc98a0008007ab6

@ia0
Copy link
Contributor Author

ia0 commented May 13, 2024

This actually depends on #150 to pass CI.

@jamesmunns
Copy link
Owner

CC @ia0, I'm not actually sure what the failing line is supposed to do, it was introduced in #108 by @dtolnay, it's possible this is only intended to be activated in docs-rs with a nightly build, if so should we avoid activating this in CI?

@jamesmunns
Copy link
Owner

This is the failing line btw, it is complaining about the use of #![feature(...)] on stable:

#![cfg_attr(docsrs, feature(doc_cfg))]

@ia0
Copy link
Contributor Author

ia0 commented May 13, 2024

The last commit should fix it. We should indeed only test the documentation in nightly. Also regarding the doc_cfg feature, we could probably simplify the code by using auto_doc_cfg instead. This could be done in another PR (after #151).

@jamesmunns jamesmunns merged commit 5fa649a into jamesmunns:main May 13, 2024
5 checks passed
@ia0 ia0 mentioned this pull request May 13, 2024
@ia0 ia0 deleted the doc branch May 13, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants