Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somethings odd with the import path #166

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Somethings odd with the import path #166

merged 2 commits into from
Aug 20, 2024

Conversation

jamesmunns
Copy link
Owner

CC @Manishearth, I plan to do a release, but somethings funky with the cargo package and relative path imports to readmes.

I'll take a look at this in a bit.

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for cute-starship-2d9c9b canceled.

Name Link
🔨 Latest commit d89290f
🔍 Latest deploy log https://app.netlify.com/sites/cute-starship-2d9c9b/deploys/66c3dccee2a6dc0008222b47

@jamesmunns
Copy link
Owner Author

R-A and cargo package complain with either option:

error: couldn't read `src/../../../README.md`: No such file or directory (os error 2)
 --> src/lib.rs:3:33
  |
3 | #![cfg_attr(not(doctest), doc = include_str!("../../../README.md"))]
  |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in the macro `include_str` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a file with the same name in a different directory
  |
3 | #![cfg_attr(not(doctest), doc = include_str!("../../../../README.md"))]
  |                                              ~~~~~~~~~~~~~~~~~~~~~~~

error: could not compile `postcard` (lib) due to 1 previous error
error: failed to verify package tarball

@Manishearth
Copy link
Contributor

Yeah in ICU4X we copy the license file around to avoid using relative paths like that. I forget if it was because it was broken-ish, or completely broken, but that might end up being the call. You can also check in a symlink into git (it'll become a regular file on publish, iirc)

@Manishearth
Copy link
Contributor

(however git symlinks are weird on windows. i forgot in what way)

@robertbastian
Copy link

Windows needs admin privileges to create symlinks, so by default git creates a copy.

@jamesmunns
Copy link
Owner Author

Decided to just copy the file for now, to get this released.

@jamesmunns jamesmunns merged commit 96f8be9 into main Aug 20, 2024
5 checks passed
@jamesmunns jamesmunns deleted the james/prepare-release branch August 20, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants